chore: consolidate datasource import logic #11533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11533 +/- ##
==========================================
- Coverage 62.25% 55.42% -6.84%
==========================================
Files 874 406 -468
Lines 42325 14344 -27981
Branches 3972 3691 -281
==========================================
- Hits 26350 7950 -18400
+ Misses 15795 6231 -9564
+ Partials 180 163 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
reviewed
Nov 3, 2020
| @@ -324,7 +325,7 @@ def run(self) -> None: | |||
| self.validate() | |||
|
|
|||
| for file_name, content in self.contents.items(): | |||
| logger.info(f"Importing dashboard from file {file_name}") | |||
| logger.info("Importing dashboard from file %s", file_name) | |||
There was a problem hiding this comment.
@hughhhh when logging pylint actually recommends string interpolation, since it's faster (the string is interpolated only if the log level is being recorded) and safer (if the string interpolation fails something is still logged). I changed it here because pylint was complaining.
hughhhh
approved these changes
Nov 3, 2020
betodealmeida
force-pushed
the
command_import_datasource
branch
from
40b607d to
6ea9908
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Consolidate dash import logic * WIP * Add license * Fix lint * Retrigger tests * Fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a stacked PR, dependent on #11529.
SUMMARY
Currently the import functionality of Superset is split between the
ImportExportMixinand theimport_objmethod in some of the models.This PR finalizes the process of getting rid of the
import_objmethod, started in #11529, consolidating all the import functionality in a single place to make it easier to preserve backwards compatibility once we implement #11167.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Updated unit tests.
ADDITIONAL INFORMATION