-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqla): allow 'unknown' type queries in explore view #11365
fix(sqla): allow 'unknown' type queries in explore view #11365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @serenajiang for the fix, apologies for the inconvenience!
Btw, I'm surprised |
Codecov Report
@@ Coverage Diff @@
## master #11365 +/- ##
==========================================
- Coverage 65.75% 56.20% -9.56%
==========================================
Files 838 406 -432
Lines 39716 13564 -26152
Branches 3615 3443 -172
==========================================
- Hits 26116 7623 -18493
+ Misses 13499 5771 -7728
- Partials 101 170 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
After we deployed #11236, several charts broke because the sql parser could not identify the type of the query and pessimistically classified them as write queries. These problems occur because the sql parser is sensitive to certain syntax issues that may not actually be problems in some dialects of sql (in this case, presto sql).
These errors are confusing to users because their queries work in sql lab but fail in explore view. Debugging and fixing the so-called "incorrect" syntax is very tedious.
In this PR, I am allowing queries with an "UNKNOWN" type (optimistic instead of pessimistic). This couuuuld potentially allow some write queries through, but it's still a step up from how things were before #11236.
TEST PLAN
Some examples of correct queries that failed in explore view due to unknown type:
ADDITIONAL INFORMATION