-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SpatialControl popover won't open #11127
Conversation
Recently a change related to emotion styling not properly working through react-bootstrap's popover broke the SpatialControl. This PR makes SpatialControl use antd's equivalent, and addresses the issue as a result: emotion's styling context is preserved through this superior popover.
Codecov Report
@@ Coverage Diff @@
## master #11127 +/- ##
==========================================
- Coverage 65.73% 60.10% -5.63%
==========================================
Files 819 385 -434
Lines 38865 24323 -14542
Branches 3669 0 -3669
==========================================
- Hits 25546 14619 -10927
+ Misses 13209 9704 -3505
+ Partials 110 0 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1ddd7ee
to
5662918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I want to give @kgabryje the chance to take a look at this and make any comments/suggestions before merging, since I know he's planning to do exactly this, across the board.
|
||
// Eventually Popover can be wrapped and customized in this file | ||
// for now we're just redirecting | ||
export default Popover; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how we feel about the appearance of the popover, we may not need to do this, but I like this scaffolding to set us up for a little Emotion styling here. If the day comes that we do tweak the styles, let's just be sure to add it to Storybook!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I didn't know if we wanted to do this redirect here. Main goal was to fix SpatialControl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good pattern to do this, actually.
Recently a change related to emotion styling not properly working through react-bootstrap's popover broke the SpatialControl. This PR makes SpatialControl use antd's equivalent, and addresses the issue as a result: emotion's styling context is preserved through this superior popover.
Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.
This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.