Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: url parameter was covering class parameter #10911

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix: url parameter was covering class parameter #10911

merged 1 commit into from
Sep 17, 2020

Conversation

kkucharc
Copy link
Contributor

SUMMARY

Suggestion of renaming url parameter in models/core.py:

  • removed disabled pylint rule: redefined-outer-name from file
  • url parameter is renamed in several methods so it's not misleading in code.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@mistercrunch mistercrunch changed the title Fix: url parameter was covering class parameter fix: url parameter was covering class parameter Sep 16, 2020
@kkucharc
Removed disabled linting redefined-outer-name. Url parameters are ren…
1efd2ca 
…amed where url was already defined in class attributes
@kkucharc
Copy link
Contributor Author

@mistercrunch Thank you for review. I just applied changes from master to see if my PR doesn't break anything. CC: @willbarrett

@mistercrunch mistercrunch merged commit cd77797 into apache:master Sep 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@kkucharc @auxten
Removed disabled linting redefined-outer-name. Url parameters are ren…
3adec64 
…amed where url was already defined in class attributes (apache#10911)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkucharc @mistercrunch