Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only call signal if executing on the main thread #10677

Merged
merged 2 commits into from
Aug 25, 2020
Merged

fix: only call signal if executing on the main thread #10677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7960cca
SO-809 possible fix?
henryyeh Aug 25, 2020
7d4b2b5
SO-809 possible fix?
henryyeh Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions superset/utils/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import signal
import smtplib
import tempfile
import threading
import traceback
import uuid
import zlib
Expand Down Expand Up @@ -631,8 +632,9 @@ def handle_timeout( # pylint: disable=unused-argument

def __enter__(self) -> None:
try:
signal.signal(signal.SIGALRM, self.handle_timeout)
signal.alarm(self.seconds)
if threading.current_thread() == threading.main_thread():
signal.signal(signal.SIGALRM, self.handle_timeout)
signal.alarm(self.seconds)
except ValueError as ex:
logger.warning("timeout can't be used in the current context")
logger.exception(ex)
Expand Down