feat: updated email format for SQL-based email alerts #10512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Aug 4, 2020
superset/tasks/schedules.py
Outdated
| @@ -602,10 +604,16 @@ def deliver_alert(alert: Alert, recipients: Optional[str] = None) -> None: | |||
| textwrap.dedent( | |||
| """\ | |||
| <h2>Alert: %(label)s</h2> | |||
| <img src="cid:screenshot" alt="%(label)s" /> | |||
| <p><b>SQL Statement: </b>%(sql)s</p> | |||
| <p>Click <a href="%(image_url)s">here</a> or the image below | |||
There was a problem hiding this comment.
you can probably do even better here:
https://stackoverflow.com/questions/17245895/how-to-format-text-in-email-when-using-smtp
e.g.
- highlight sql section & use separate font
- show the result returned
- use red color
- have a link to the alert history
There was a problem hiding this comment.
also template may live separately, e.g. https://github.com/apache/incubator-superset/blob/master/superset/templates/email/role_extended.txt
There was a problem hiding this comment.
I'll leave show the result returned as a TODO
bkyryliuk
reviewed
Aug 4, 2020
bkyryliuk
requested changes
Aug 4, 2020
JasonD28
force-pushed
the
jdavis_alerting_email_ui
branch
from
df15ae9 to
514fff8
Compare
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
* added sql statement and link to chart in alert email * pylint * updated email to include link to alert * style changes * pylint * added todo and fixed formatting of email Co-authored-by: Jason Davis <@dropbox.com>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* added sql statement and link to chart in alert email * pylint * updated email to include link to alert * style changes * pylint * added todo and fixed formatting of email Co-authored-by: Jason Davis <@dropbox.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added the relevant SQL statement and a link to the relevant slice for SQL-based email alerts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION