Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Implement updates to SQL-based email alerts #10454

Merged
merged 4 commits into from
Jul 28, 2020
Merged

fix: Implement updates to SQL-based email alerts #10454

merged 4 commits into from
Jul 28, 2020

Conversation

JasonD28
Copy link
Contributor

SUMMARY

  • Added unit testing for some functionality introduced through SQL-based email alerts
  • Removed unused fields from AlertModelView
  • Fix retention of past calls made to alert schedules
    • The celery alerting task is meant to be invoked every minute, however the previous implementation of schedule_window() ignored the timestamp of previous calls to alerting schedules, this resulted in alerts being sent out every time the task was invoked

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@bkyryliuk bkyryliuk self-requested a review July 28, 2020 19:42
bkyryliuk
bkyryliuk reviewed Jul 28, 2020
View reviewed changes
tests/alerts_tests.py Outdated


class TestAlerts(SupersetTestCase):
def setUp(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use pytest fixtures, superset uses pytest now

bkyryliuk
bkyryliuk approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG%nit

@bkyryliuk bkyryliuk merged commit d065633 into apache:master Jul 28, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@JasonD28 @auxten
fix: Implement updates to SQL-based email alerts (apache#10454)
2677ae2 
* implemented updates to alerting

* fixed imports and teardown

* changed unittest to pytest conventions

* add app_context to tests

Co-authored-by: Jason Davis <@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkyryliuk bkyryliuk bkyryliuk approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonD28 @bkyryliuk @mistercrunch