feat: adding Storybook to Superset #10383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10383 +/- ##
==========================================
+ Coverage 65.44% 69.75% +4.30%
==========================================
Files 603 196 -407
Lines 32418 19026 -13392
Branches 3297 0 -3297
==========================================
- Hits 21215 13271 -7944
+ Misses 11019 5755 -5264
+ Partials 184 0 -184
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@nytai this seems to be failing CI due to some TS errors around list view components. Not sure how that slipped in here, but maybe you can help? |
| }, | ||
| defaultValue: null, | ||
| }; | ||
| // TODO remove the use of these in the codebase where they're not necessary |
There was a problem hiding this comment.
Leaving this here for the moment... it's the result of taking inventory, and I'll remove these comments as I (at least try to) remove these classes from the codebase
Interesting question... not sure! But I'll note the task for investigation and a potential follow-up PR. |
* Storybook added! * starting to configure junk.... * Storybook works!!! * Now with theme! * apache boilerplate * more apache comments * lots o' knobs for the Button.... taking stock of the codebase * more classes, but killing the knob for now. * nixing unused module * linting * fresh package-lock * now with tooltip! * adding path and zlip because the linter told me to * upgrading storybook packages from devdeps * linting * removing cruft * killing an annoying (and old?) lint issue * lint fix, take 2. * removing zlib/path * package lock reset from master * re-adding new packages for this here PR * nixing console log, simplifying * nixing comment TODOs (done enough!) * basic docs.
|
Roadmap: apache-superset/superset-roadmap#23 |
mistercrunch
added
🏷️ bot
SUMMARY
So far, there's not much here... just a humble button, but it all loads, webpack works, and both the LESS codebase and the Emotion theme are applied to all stories.
This PR only adds the story for the button. More coming in subsequent PRs.
The stories for a component are recommended to be next to the component itself, neighboring the component's
[jt]sxfiles.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
npm run storybookfrom withinsuperset-frontendADDITIONAL INFORMATION