Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: type src/addSlice #10127

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jun 22, 2020

SUMMARY

As titled, related to #10004

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After (everything looks the same):
Screen Shot 2020-06-21 at 9 42 05 PM

TEST PLAN

CI, manual testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @graceguo-supercat @ktmud @nytai

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etr2460 etr2460 force-pushed the erik-ritter--type-src-addSlice branch from c952d57 to 170e58f Compare June 22, 2020 14:56
@etr2460 etr2460 force-pushed the erik-ritter--type-src-addSlice branch from 170e58f to 8456c79 Compare June 22, 2020 15:01
@etr2460 etr2460 merged commit cb1705f into apache:master Jun 22, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants