Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security): Renaming schemas_accessible_by_user #10030

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR renames the schemas_accessible_by_user function to get_schemas_accessible_by_user which is consistent with the get_datasources_accessible_by_user method.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--security-manager-cleanup branch from ae431e6 to d824716 Compare June 10, 2020 16:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #10030 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10030   +/-   ##
=======================================
  Coverage   70.47%   70.47%           
=======================================
  Files         583      583           
  Lines       31019    31019           
  Branches     3175     3175           
=======================================
  Hits        21861    21861           
  Misses       9049     9049           
  Partials      109      109           
Flag Coverage Δ
#cypress 53.92% <ø> (ø)
#javascript 59.41% <ø> (ø)
#python 70.06% <50.00%> (ø)
Impacted Files Coverage Δ
superset/views/database/forms.py 90.69% <0.00%> (ø)
superset/views/core.py 76.27% <50.00%> (ø)
superset/security/manager.py 89.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17da58...a44063b. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the security manager is a somewhat public API (we recommend people override this as necessary) should we add a line to UPDATING.md noting the function name change?

@john-bodley john-bodley force-pushed the john-bodley--security-manager-cleanup branch from d824716 to a44063b Compare June 10, 2020 17:02
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave schemas_accessible_by_user as an alias for a version or two with a deprecation warning?

@john-bodley
Copy link
Member Author

@villebro I think that's generally a good idea however for #10031 (which is similar) there's actually name conflicts due the renaming and thus it is not viable to keep both the old and new forms.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that makes sense. Adding a comment about this being necessary partly due to name conflicts might add context for admins (completely optional).

@john-bodley john-bodley merged commit 54c6ddb into apache:master Jun 11, 2020
@john-bodley john-bodley deleted the john-bodley--security-manager-cleanup branch June 11, 2020 18:29
michellethomas pushed a commit to airbnb/superset-fork that referenced this pull request Jun 17, 2020
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jun 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants