New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double underscore causes problems for some SQL #495

Closed

joshwalters opened this issue May 19, 2016 · 1 comment

Contributor

joshwalters commented May 19, 2016 •

edited

Loading

Some SQL engines can't handle double underscore ('__') as a column prefix: https://github.com/airbnb/caravel/blob/master/caravel/models.py#L632
https://github.com/airbnb/caravel/blob/master/caravel/models.py#L718

This can be fixed by using '__' as a suffix instead.

Does this sound reasonable? If so I will make a patch to fix this.

An alternative is to use backticks to escape the column, but that only works for some SQL engines, others need square brackets.

joshwalters mentioned this issue

Made '__' prefix into suffix. #496

Merged

Contributor Author

joshwalters commented May 20, 2016

Issue resolved and merged.

joshwalters closed this as completed

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps): bump @types/lodash from 4.14.150 to 4.14.151 (apache#495)

73691b0

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.150 to 4.14.151.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps): bump @types/lodash from 4.14.150 to 4.14.151 (apache#495)

8d0e7e8

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.150 to 4.14.151.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps): bump @types/lodash from 4.14.150 to 4.14.151 (apache#495)

d4f363c

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.150 to 4.14.151.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps): bump @types/lodash from 4.14.150 to 4.14.151 (apache#495)

c9957f9

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.150 to 4.14.151.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment