-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supersetEmbeddedSdk filters.visible = false doesn't seem to work #24195
Comments
I'm facing the same issue here. |
Is there documentation somewhere that claims this works? I don't think this feature exists, so I'm hesitant to say this is a bug. This is probably a feature request, unless I'm missing something? |
Apparently, it used to be a feature, but it was deprecated, at least, that was what I was told in a preset call about how to embed dashboards. Superset doesn't have docs about how to handle this in CSS either but preset does But it's not a very clean way to do this, we need to apply thar CSS to every dashboard.. filters become hidden in the main web UI to not just embedding, it also doesn't really remove them... just sets a display:none... but they are still there in the html/dom.... I guess the current implementation is not ideal, feel free to mark this a FR if you think its not a bug but there were other folks on slack also asking about this so it does seem like it was supported at some point in the SDK. |
@rusackas On the SDK docs there is an example showing that there is an option to hide filters using the superset/superset-embedded-sdk/README.md Lines 43 to 47 in 62b4564
|
Hmm.... the docs say "expanded" not "visible" - that would make a difference. Even then, I think that just sets the bar to collapsed rather than expanded. It's not gone just closed. |
Maybe this helps:
eb80568
``` /** The dashboard UI config: hideTitle, hideTab, hideChartControls,
filters.visible, filters.expanded **/ ``` <---
which no longer seems to be the case... there's also several posts in slack
about this... and even examples posted on how to hide filters...
Maybe that was always buggy and got removed... that much I don't know
because the release notes unfortunately don't mention this and I was lazy
to dig into more code or PRs etc
Anyway the fact is there is a lot of evidence to suggest this was indeed a
thing, and it no longer is, so if you want to set this as FR instead of BUG
I think it's fine, but it's definitely much needed, there's more than one
thread on slack, I just decided to bring it over Github because it seemed
like the correct approach perhaps it wasn't
|
It was indeed a feature, i was relying on it. After updating superset today, I got this issue. |
@herrlegno which version of superset you were using before the update? |
@matheusbsilva I can't tell you for sure, because I cloned the repo not from dockerhub. I think it was 2.1.0rc1 because the reason for updating was the screenshot generation was broken. I hope this is helpful enough. |
Digging into the commits history I found the one that added this feature: b7ecb14. And apparently the option was removed here: 5f0c320, not sure why. It would be great if @john-bodley could give us more context on why this option was removed because It is a great feature to have, maybe we can find a way to add it again. |
@matheusbsilva reading through #23228 it was likely removing |
Do we know what this bus is going to be fixed? |
Any updates on this? |
This was a very good feature, can we please add it back as were before. Thanks. |
* fix(sqllab): reinstate "Force trino client async execution" (apache#25680) * fix: remove unnecessary redirect (apache#25679) (cherry picked from commit da42bf2) * fix(chore): dashboard requests to database equal the number of slices it has (apache#24709) (cherry picked from commit 75a7431) * fix: bump to FAB 4.3.9 remove CSP exception (apache#25712) (cherry picked from commit 8fb0c8d) * fix(horizontal filter label): show full tooltip with ellipsis (apache#25732) (cherry picked from commit e4173d9) * fix: Revert "fix(Charts): Set max row limit + removed the option to use an empty row limit value" (apache#25753) (cherry picked from commit e2fe967) * fix: dataset update uniqueness (apache#25756) (cherry picked from commit c7f8d11) * fix(sqllab): slow pop datasource query (apache#25741) (cherry picked from commit 2a2bc82) * fix: allow for backward compatible errors (apache#25640) * fix: DB-specific quoting in Jinja macro (apache#25779) (cherry picked from commit 5659c87) * fix: Revert "fix: Apply normalization to all dttm columns (apache#25147)" (apache#25801) * fix: Resolve issue apache#24195 (apache#25804) (cherry picked from commit 8737a8a) * fix(SQL field in edit dataset modal): display full sql query (apache#25768) (cherry picked from commit 1eba712) * fix(sqllab): infinite fetching status after results are landed (apache#25814) (cherry picked from commit 3f28eeb) * fix: Fires onChange when clearing all values of single select (apache#25853) (cherry picked from commit 8061d5c) * fix: the temporal x-axis results in a none time_range. (apache#25429) Co-authored-by: Elizabeth Thompson <[email protected]> (cherry picked from commit ae619b1) * fix(table chart): Show Cell Bars correctly apache#25625 (apache#25707) (cherry picked from commit 916f7bc) * fix: remove `update_charts_owners` (apache#25843) * fix(charts): Time grain is None when dataset uses Jinja (apache#25842) (cherry picked from commit 7536dd1) * fix: Saving Mixed Chart with dashboard filter applied breaks adhoc_filter_b (apache#25877) (cherry picked from commit 268c1dc) * fix: database version field (apache#25898) (cherry picked from commit 06ffcd2) * fix: trino cursor (apache#25897) (cherry picked from commit cdb18e0) * chore: Updates CHANGELOG.md for 3.0.2 * fix(trino): allow impersonate_user flag to be imported (apache#25872) Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 458be8c) * fix(table): Double percenting ad-hoc percentage metrics (apache#25857) (cherry picked from commit 784a478) * fix(sqllab): invalid sanitization on comparison symbol (apache#25903) (cherry picked from commit 581d3c7) * fix: update flask-caching to avoid breaking redis cache, solves apache#25339 (apache#25947) Co-authored-by: Ville Brofeldt <[email protected]> * fix: always denorm column value before querying values (apache#25919) * chore(colors): Updating Airbnb brand colors (apache#23619) (cherry picked from commit 6d8424c) * fix: naming denomalized to denormalized in helpers.py (apache#25973) (cherry picked from commit 5def416) * fix(helm): Restart all related deployments when bootstrap script changed (apache#25703) * fix(rls): Update text from tables to datasets in RLS modal (apache#25997) (cherry picked from commit 210f1f8) * fix: Make Select component fire onChange listener when a selection is pasted in (apache#25993) (cherry picked from commit 5fccf67) * fix(explore): redandant force param (apache#25985) (cherry picked from commit e7a1876) * chore: Optimize fetching samples logic (apache#25995) (cherry picked from commit 326ac4a) * fix(native filters): rendering performance improvement by reduce overrendering (apache#25901) (cherry picked from commit e1d73d5) * fix: update FAB to 4.3.10, Azure user info fix (apache#26037) (cherry picked from commit 628cd34) * chore: Updates CHANGELOG.md for 3.0.2 (rc2) --------- Co-authored-by: Rob Moore <[email protected]> Co-authored-by: Igor Khrol <[email protected]> Co-authored-by: Stepan <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Ross Mabbett <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: John Bodley <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: mapledan <[email protected]> Co-authored-by: Arko <[email protected]> Co-authored-by: Antonio Rivero <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: FGrobelny <[email protected]> Co-authored-by: Giacomo Barone <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: josedev-union <[email protected]> Co-authored-by: yousoph <[email protected]> Co-authored-by: Jack Fragassi <[email protected]>
was this issue merged for 3.1.0 ? |
3.1 was a cut from master, so I believe so. |
I am running Superset version: 4.0.1
filters.expanded: false works but filters.visible: false doesn't work. This code is taken from the README from: https://github.com/apache/superset/tree/master/superset-embedded-sdk |
A clear and concise description of what the bug is.
How to reproduce the bug
Expected results
filter sidebar show not be visible
Actual results
filter sidebar is still visible,
expanded: false
does work though so it seems to be only visible that doesn't take efect.Screenshots
Environment
(please complete the following information):
Firefox 113 and Safari 16.4 both on macos
Using docker apache/superset:latest build yesterday
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: