We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a user is not Admin, but is granted "menu_access on Manage" permission through other roles, the user won't be able to see "Set up email report" button in the drop down menu on Dashboards or charts unless the first role has "menu_access on Manage" permission. This is because on line 123 of this file https://github.com/apache/superset/blob/master/superset-frontend/src/components/ReportModal/HeaderReportDropdown/index.tsx#L118-L123 , it only checks the first role.
If a user has been granted the correct permission, the user should be able to see the "Set up email report" button
the "Set up email report" button doesn't show up
N/A
(please complete the following information):
Make sure to follow these steps before submitting your issue - thank you!
Will send a PR later to fix the issue
The text was updated successfully, but these errors were encountered:
7f971b4
fix(report): Fix permission check for set up email report on charts/d…
b1c9adb
…ashboards. Fixes apache#21559 (apache#21561) Co-authored-by: Rui Zhao <[email protected]> (cherry picked from commit 7f971b4)
528b271
3eca285
No branches or pull requests
If a user is not Admin, but is granted "menu_access on Manage" permission through other roles, the user won't be able to see "Set up email report" button in the drop down menu on Dashboards or charts unless the first role has "menu_access on Manage" permission. This is because on line 123 of this file https://github.com/apache/superset/blob/master/superset-frontend/src/components/ReportModal/HeaderReportDropdown/index.tsx#L118-L123 , it only checks the first role.
How to reproduce the bug
Expected results
If a user has been granted the correct permission, the user should be able to see the "Set up email report" button
Actual results
the "Set up email report" button doesn't show up
Screenshots
N/A
Environment
(please complete the following information):
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
Will send a PR later to fix the issue
The text was updated successfully, but these errors were encountered: