Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to define the 'SameSite' for Global Async Query async-token cookie #21183

Closed
3 tasks done
rdubois opened this issue Aug 24, 2022 · 0 comments · Fixed by #21185
Closed
3 tasks done

Unable to define the 'SameSite' for Global Async Query async-token cookie #21183

rdubois opened this issue Aug 24, 2022 · 0 comments · Fixed by #21185
Assignees
@villebro
Labels
#bug Bug report

Comments

@rdubois
Copy link
Contributor

rdubois commented Aug 24, 2022 •
edited
Loading

For the session cookie, the Superset configuration allows to override the default behaviour and configure the SameSite option through the SESSION_COOKIE_SAMESITE variable.
That option is not available for the Global Async Token JWT cookie. The default value None is then considered.

Environment

(please complete the following information):

  • superset version: 1.5.1 / 2.0.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@rdubois rdubois added the #bug Bug report label Aug 24, 2022
@rdubois rdubois changed the title Unable to define the 'SameSite' for Global Asyn Query asyn-token cookie Unable to define the 'SameSite' for Global Async Query async-token cookie Aug 24, 2022
rdubois added a commit to rdubois/superset that referenced this issue Aug 24, 2022
@rdubois
fix(apache#21183): Make global async. queries cookie SameSite option …
968ba27 
…configurable
rdubois added a commit to rdubois/superset that referenced this issue Aug 24, 2022
@rdubois
fix(apache#21183): make global async. queries cookie SameSite option …
bf479b7 
…configurable
@rdubois rdubois mentioned this issue Aug 24, 2022
Merged
9 tasks
ftom pushed a commit to ftom/superset that referenced this issue Aug 29, 2022
@rdubois
fix(apache#21183): Make global async. queries cookie SameSite option …
97dcceb 
…configurable (#2)
rdubois added a commit to ftom/superset that referenced this issue Aug 30, 2022
@rdubois
fix(apache#21183): Make global async. queries cookie SameSite option …
f9d6f74 
…configurable (#2)
@rdubois rdubois mentioned this issue Aug 30, 2022
Merged
9 tasks
ftom pushed a commit to ftom/superset that referenced this issue Aug 30, 2022
@rdubois
fix(apache#21183): Make global async. queries cookie SameSite option …
10ef046 
…configurable (#2) (#4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@villebro villebro

Labels
#bug Bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(async-queries): make global async. queries cookie SameSite option configurable rdubois/superset
2 participants
@rdubois @villebro