Skip to content

Commit

Permalink
fix(heatmap): add detail descriptions for heatmap 'normalize across' (#…
Browse files Browse the repository at this point in the history
…20566)

* fix(heatmap): change 'Normalize Across' to 'Color Based On' and add some label

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <[email protected]>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <[email protected]>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <[email protected]>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <[email protected]>

* fix lint

Co-authored-by: Evan Rusackas <[email protected]>
  • Loading branch information
stephenLYZ and rusackas authored Jul 20, 2022
1 parent 2a4c7cf commit d925b0c
Showing 1 changed file with 18 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import {
FeatureFlag,
isFeatureEnabled,
Expand Down Expand Up @@ -170,10 +171,23 @@ const config: ControlPanelConfig = {
['y', 'y'],
],
default: 'heatmap',
description: t(
'Color will be rendered based on a ratio ' +
'of the cell against the sum of across this ' +
'criteria',
description: (
<>
<div>
{t(
'Color will be shaded based the normalized (0% to 100%) value of a given cell against the other cells in the selected range: ',
)}
</div>
<ul>
<li>{t('x: values are normalized within each column')}</li>
<li>{t('y: values are normalized within each row')}</li>
<li>
{t(
'heatmap: values are normalized across the entire heatmap',
)}
</li>
</ul>
</>
),
},
},
Expand Down

0 comments on commit d925b0c

Please sign in to comment.