Address Comments

apache · Jan 18, 2021 · cca9364 · cca9364
1 parent 3ccae72
commit cca9364
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/superset-frontend/src/explore/components/SaveModal.tsx b/superset-frontend/src/explore/components/SaveModal.tsx
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
 
 // Session storage key for recent dashboard
 const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('Select dashboard');
+const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
 
 type SaveModalProps = {
   can_overwrite?: boolean;
@@ -153,7 +153,10 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
 
   render() {
     const dashboardSelectValue =
-      this.state.newDashboardName || this.state.saveToDashboardId;
+      this.state.saveToDashboardId || this.state.newDashboardName;
+    const valueObj = dashboardSelectValue
+      ? { value: dashboardSelectValue }
+      : null;
     return (
       <Modal
         show
@@ -244,14 +247,13 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
             <CreatableSelect
               id="dashboard-creatable-select"
               className="save-modal-selector"
+              menuPosition="fixed"
               options={this.props.dashboards}
               clearable
               creatable
               onChange={this.onDashboardSelectChange}
               autoSize={false}
-              value={
-                dashboardSelectValue ? { value: dashboardSelectValue } : null
-              }
+              value={valueObj}
               placeholder={
                 // Using markdown to allow for good i18n
                 <ReactMarkdown