fix: reduce alert error to warning (#27744)

(cherry picked from commit 70da454)
apache · Mar 28, 2024 · c377ccf · c377ccf
1 parent 19b05d3
commit c377ccf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/superset-frontend/src/components/Chart/chartAction.js b/superset-frontend/src/components/Chart/chartAction.js
@@ -375,7 +375,7 @@ export function addChart(chart, key) {
 }
 
 export function handleChartDataResponse(response, json, useLegacyApi) {
-  if (isFeatureEnabled(FeatureFlag.GlobalAsyncQueries)) {
+  if (isFeatureEnabled(FeatureFlag.GLOBAL_ASYNC_QUERIES)) {
     // deal with getChartDataRequest transforming the response data
     const result = 'result' in json ? json.result : json;
     switch (response.status) {

diff --git a/superset-frontend/src/components/Chart/chartActions.test.js b/superset-frontend/src/components/Chart/chartActions.test.js
@@ -83,7 +83,7 @@ describe('chart actions', () => {
     waitForAsyncDataStub.restore();
 
     global.featureFlags = {
-      [FeatureFlag.GlobalAsyncQueries]: false,
+      [FeatureFlag.GLOBAL_ASYNC_QUERIES]: false,
     };
   });
 
@@ -136,7 +136,7 @@ describe('chart actions', () => {
 
     it('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and results are returned synchronously', async () => {
       global.featureFlags = {
-        [FeatureFlag.GlobalAsyncQueries]: true,
+        [FeatureFlag.GLOBAL_ASYNC_QUERIES]: true,
       };
       const result = await handleChartDataResponse(
         { status: 200 },
@@ -147,7 +147,7 @@ describe('chart actions', () => {
 
     it('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and query is running asynchronously', async () => {
       global.featureFlags = {
-        [FeatureFlag.GlobalAsyncQueries]: true,
+        [FeatureFlag.GLOBAL_ASYNC_QUERIES]: true,
       };
       const result = await handleChartDataResponse(
         { status: 202 },

diff --git a/superset/commands/report/alert.py b/superset/commands/report/alert.py
@@ -169,7 +169,7 @@ def _execute_query(self) -> pd.DataFrame:
             logger.warning("A timeout occurred while executing the alert query: %s", ex)
             raise AlertQueryTimeout() from ex
         except Exception as ex:
-            logger.exception("An error occurred when running alert query")
+            logger.warning("An error occurred when running alert query")
             # The exception message here can reveal to much information to malicious
             # users, so we raise a generic message.
             raise AlertQueryError(