[bugfix] filter widgets to apply on applicable Slices (#658)

Also fixed a white on white issue on hover
apache · Jun 22, 2016 · 8ebe074 · 8ebe074
1 parent f25e375
commit 8ebe074
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/caravel/assets/visualizations/filter_box.css b/caravel/assets/visualizations/filter_box.css
@@ -6,3 +6,17 @@
 .dashboard .filter_box .slice_container > div {
   padding-top: 0;
 }
+
+ul.select2-results li.select2-highlighted div.filter_box{
+ color: black;
+ border-width: 1px;
+ border-style: solid;
+ border-color: #666;
+}
+
+ul.select2-results div.filter_box{
+ color: black;
+ border-style: solid;
+ border-width: 1px;
+ border-color: transparent;
+}
diff --git a/caravel/viz.py b/caravel/viz.py
@@ -189,7 +189,8 @@ def query_filters(self, is_having_filter=False):
             for slice_filters in extra_filters.values():
                 for col, vals in slice_filters.items():
                     if col and vals:
-                        filters += [(col, 'in', ",".join(vals))]
+                        if col in self.datasource.filterable_column_names:
+                            filters += [(col, 'in', ",".join(vals))]
         return filters
 
     def query_obj(self):