check for access before requesting access (#4469)

apache · Feb 28, 2018 · 8626793 · 8626793
1 parent c2b42c4
commit 8626793
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/superset/views/core.py b/superset/views/core.py
@@ -842,6 +842,15 @@ def request_access(self):
                 .one()
             )
             datasources.add(datasource)
+
+        has_access = all(
+            (
+                datasource and self.datasource_access(datasource)
+                for datasource in datasources
+            ))
+        if has_access:
+            return redirect('/superset/dashboard/{}'.format(dashboard_id))
+
         if request.args.get('action') == 'go':
             for datasource in datasources:
                 access_request = DAR(