add some failsafe

apache · Jun 9, 2022 · 806ac54 · 806ac54
1 parent 484e237
commit 806ac54
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
@@ -224,12 +224,13 @@ export default class Chart extends React.Component {
   }
 
   getHeaderHeight() {
+    const marginBottom = parseInt(
+      getComputedStyle(this.headerRef).getPropertyValue('margin-bottom'),
+    );
     return this.headerRef
-      ? this.headerRef.offsetHeight +
-          parseInt(
-            getComputedStyle(this.headerRef).getPropertyValue('margin-bottom'),
-            10,
-          )
+      ? this.headerRef.offsetHeight + Number.isNaN(marginBottom)
+        ? 0
+        : marginBottom
       : DEFAULT_HEADER_HEIGHT;
   }