Skip to content

Commit

Permalink
fix: ignore ts warnings from older typescript versions (#23262)
Browse files Browse the repository at this point in the history
  • Loading branch information
eschutho authored Mar 2, 2023
1 parent 9d0eea9 commit 7d8383c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions superset-embedded-sdk/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-embedded-sdk/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@superset-ui/embedded-sdk",
"version": "0.1.0-alpha.8",
"version": "0.1.0-alpha.9",
"description": "SDK for embedding resources from Superset into your own application",
"access": "public",
"keywords": [
Expand Down
2 changes: 2 additions & 0 deletions superset-embedded-sdk/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export async function embedDashboard({
});

iframe.src = `${supersetDomain}/embedded/${id}${dashboardConfig}${filterConfigUrlParams}`;
//@ts-ignore
mountPoint.replaceChildren(iframe);
log('placed the iframe')
});
Expand All @@ -173,6 +174,7 @@ export async function embedDashboard({

function unmount() {
log('unmounting');
//@ts-ignore
mountPoint.replaceChildren();
}

Expand Down

0 comments on commit 7d8383c

Please sign in to comment.