chore: Remove TimeTable.less (#19463)

* Remove TimeTable less * Remove className * Update superset-frontend/src/visualizations/TimeTable/TimeTable.jsx Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Michael S. Molina <[email protected]>
apache · Apr 6, 2022 · 73e9391 · 73e9391
1 parent f6d550b
commit 73e9391
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 26 deletions.
diff --git a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/time_table.js b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/time_table.js
@@ -47,7 +47,7 @@ describe('Visualization > Time TableViz', () => {
       waitAlias: '@getJson',
       querySubstring: NUM_METRIC.label,
     });
-    cy.get('.time-table').within(() => {
+    cy.get('[data-test="time-table"]').within(() => {
       cy.get('span').contains('Sum(num)');
       cy.get('span').contains('COUNT(*)');
     });
@@ -75,7 +75,7 @@ describe('Visualization > Time TableViz', () => {
       waitAlias: '@getJson',
       querySubstring: NUM_METRIC.label,
     });
-    cy.get('.time-table').within(() => {
+    cy.get('[data-test="time-table"]').within(() => {
       cy.get('td').contains('boy');
       cy.get('td').contains('girl');
     });
@@ -112,7 +112,7 @@ describe('Visualization > Time TableViz', () => {
       waitAlias: '@getJson',
       querySubstring: NUM_METRIC.label,
     });
-    cy.get('.time-table').within(() => {
+    cy.get('[data-test="time-table"]').within(() => {
       cy.get('th').contains('Current');
       cy.get('th').contains('Last Year');
       cy.get('th').contains('YoY');

diff --git a/superset-frontend/src/visualizations/TimeTable/TimeTable.jsx b/superset-frontend/src/visualizations/TimeTable/TimeTable.jsx
@@ -31,7 +31,6 @@ import sortNumericValues from 'src/utils/sortNumericValues';
 
 import FormattedNumber from './FormattedNumber';
 import SparklineCell from './SparklineCell';
-import './TimeTable.less';
 
 const ACCESSIBLE_COLOR_BOUNDS = ['#ca0020', '#0571b0'];
 
@@ -101,6 +100,7 @@ const defaultProps = {
 
 const TimeTableStyles = styled.div`
   height: ${props => props.height}px;
+  overflow: auto;
 
   th {
     z-index: 1; // to cover sparkline
@@ -325,7 +325,11 @@ const TimeTable = ({
       : [];
 
   return (
-    <TimeTableStyles className={`time-table ${className}`} height={height}>
+    <TimeTableStyles
+      data-test="time-table"
+      className={className}
+      height={height}
+    >
       <TableView
         className="table-no-hover"
         columns={memoizedColumns}

diff --git a/superset-frontend/src/visualizations/TimeTable/TimeTable.less b/superset-frontend/src/visualizations/TimeTable/TimeTable.less