Skip to content

Commit

Permalink
fix: logging warning on dataframe (don't use python's warnings) (#18111)
Browse files Browse the repository at this point in the history
* fix: logging warning on dataframe (don't use python's warnings)

* lint
  • Loading branch information
dpgaspar authored Jan 20, 2022
1 parent a5e805e commit 5fb8b0a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions superset/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@
# under the License.
""" Superset utilities for pandas.DataFrame.
"""
import warnings
import logging
from typing import Any, Dict, List

import pandas as pd

from superset.utils.core import JS_MAX_INTEGER

logger = logging.getLogger(__name__)


def _convert_big_integers(val: Any) -> Any:
"""
Expand All @@ -43,10 +45,8 @@ def df_to_records(dframe: pd.DataFrame) -> List[Dict[str, Any]]:
:returns: a list of dictionaries reflecting each single row of the DataFrame
"""
if not dframe.columns.is_unique:
warnings.warn(
"DataFrame columns are not unique, some columns will be omitted.",
UserWarning,
stacklevel=2,
logger.warning(
"DataFrame columns are not unique, some columns will be omitted."
)
columns = dframe.columns
return list(
Expand Down

0 comments on commit 5fb8b0a

Please sign in to comment.