fix: toggle fullscreen on the dashboard

apache · Jun 4, 2021 · 526b5a5 · 526b5a5
1 parent 004a6d9
commit 526b5a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
@@ -164,11 +164,12 @@ class HeaderActionsDropdown extends React.PureComponent {
         break;
       }
       case MENU_KEYS.TOGGLE_FULLSCREEN: {
+        const hasStandalone = !!getUrlParam(URL_PARAMS.standalone);
         const url = getDashboardUrl(
           window.location.pathname,
           getActiveFilters(),
           window.location.hash,
-          getUrlParam(URL_PARAMS.standalone),
+          !hasStandalone,
         );
         window.location.replace(url);
         break;

diff --git a/superset-frontend/src/dashboard/util/getDashboardUrl.ts b/superset-frontend/src/dashboard/util/getDashboardUrl.ts
@@ -35,7 +35,10 @@ export default function getDashboardUrl(
   );
 
   if (standalone) {
-    newSearchParams.set(URL_PARAMS.standalone.name, standalone.toString());
+    newSearchParams.set(
+      URL_PARAMS.standalone.name,
+      standalone.toString(),
+    );
   }
 
   const hashSection = hash ? `#${hash}` : '';