Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Jul 21, 2020
1 parent 8ea461a commit 32b0f52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ describe('SaveModal', () => {
wrapper.instance().saveOrOverwrite(true);
defaultProps.actions.saveSlice().then(() => {
expect(window.location.assign.callCount).toEqual(1);
console.log(window.location.assign.getCall(0).args);
expect(window.location.assign.getCall(0).args[0]).toEqual(
'http://localhost/mock_dashboard/',
);
Expand Down
10 changes: 5 additions & 5 deletions superset-frontend/src/explore/components/SaveModal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const propTypes = {

// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one')
const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');

class SaveModal extends React.Component {
constructor(props) {
Expand Down Expand Up @@ -187,9 +187,7 @@ class SaveModal extends React.Component {
/>
</FormGroup>
<FormGroup>
<ControlLabel>
{t('Add to dashboard')}
</ControlLabel>
<ControlLabel>{t('Add to dashboard')}</ControlLabel>
<CreatableSelect
id="dashboard-creatable-select"
className="save-modal-selector"
Expand All @@ -198,7 +196,9 @@ class SaveModal extends React.Component {
creatable
onChange={this.onDashboardSelectChange}
autoSize={false}
value={this.state.saveToDashboardId || this.state.newDashboardName}
value={
this.state.saveToDashboardId || this.state.newDashboardName
}
placeholder={
// Using markdown to allow for good i18n
<ReactMarkdown
Expand Down

0 comments on commit 32b0f52

Please sign in to comment.