Code review fixes

apache · Dec 17, 2020 · 197f5da · 197f5da
1 parent 3a174c4
commit 197f5da
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/superset-frontend/images/icons/fx.svg → ...rset-frontend/images/icons/function_x.svg b/superset-frontend/images/icons/fx.svg → ...rset-frontend/images/icons/function_x.svg
diff --git a/superset-frontend/spec/javascripts/explore/components/AdhocFilterControl_spec.jsx b/superset-frontend/spec/javascripts/explore/components/AdhocFilterControl_spec.jsx
@@ -20,16 +20,16 @@
 import React from 'react';
 import sinon from 'sinon';
 import { shallow } from 'enzyme';
+import { supersetTheme } from '@superset-ui/core';
 
 import AdhocFilter, {
   EXPRESSION_TYPES,
   CLAUSES,
 } from 'src/explore/AdhocFilter';
 import AdhocFilterControl from 'src/explore/components/controls/AdhocFilterControl';
+import { LabelsContainer } from 'src/explore/components/OptionControls';
 import AdhocMetric from 'src/explore/AdhocMetric';
 import { AGGREGATES, OPERATORS } from 'src/explore/constants';
-import { supersetTheme } from '@superset-ui/core';
-import { LabelsContainer } from '../../../../src/explore/components/OptionControls';
 
 const simpleAdhocFilter = new AdhocFilter({
   expressionType: EXPRESSION_TYPES.SIMPLE,

diff --git a/superset-frontend/src/components/Icon/index.tsx b/superset-frontend/src/components/Icon/index.tsx
@@ -81,7 +81,7 @@ import { ReactComponent as FilterIcon } from 'images/icons/filter.svg';
 import { ReactComponent as FilterSmallIcon } from 'images/icons/filter_small.svg';
 import { ReactComponent as FolderIcon } from 'images/icons/folder.svg';
 import { ReactComponent as FullIcon } from 'images/icons/full.svg';
-import { ReactComponent as FunctionIcon } from 'images/icons/fx.svg';
+import { ReactComponent as FunctionIcon } from 'images/icons/function_x.svg';
 import { ReactComponent as GearIcon } from 'images/icons/gear.svg';
 import { ReactComponent as GridIcon } from 'images/icons/grid.svg';
 import { ReactComponent as ImageIcon } from 'images/icons/image.svg';

diff --git a/superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx b/superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
@@ -132,6 +132,7 @@ class AdhocFilterControl extends React.Component {
                     datasource={this.props.datasource}
                     partitionColumn={partitionColumn}
                     onRemoveFilter={() => this.onRemoveFilter(index)}
+                    key={index}
                   />
                 );
               }