fixed bug in maxTagPlaceholder and value filter plugin tests

apache · Jan 17, 2023 · 0d66466 · 0d66466
1 parent 6b9b428
commit 0d66466
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
@@ -404,9 +404,9 @@ describe('Horizontal FilterBar', () => {
     saveNativeFilterSettings([SAMPLE_CHART]);
     cy.getBySel('filter-bar').within(() => {
       cy.get(nativeFilters.filterItem).contains('Albania').should('be.visible');
-      cy.get(nativeFilters.filterItem).contains('+1').should('be.visible');
+      cy.get(nativeFilters.filterItem).contains('+ 1 ...').should('be.visible');
       cy.get('.ant-select-selection-search-input').click();
-      cy.get(nativeFilters.filterItem).contains('+2').should('be.visible');
+      cy.get(nativeFilters.filterItem).contains('+ 2 ...').should('be.visible');
     });
   });
 });

diff --git a/superset-frontend/src/components/Select/Select.tsx b/superset-frontend/src/components/Select/Select.tsx
@@ -409,9 +409,10 @@ const Select = forwardRef(
 
     const customMaxTagPlaceholder = () => {
       const num_selected = ensureIsArray(selectValue).length;
+      const num_shown = maxTagCount as number;
       return selectAllMode
-        ? `+ ${num_selected - 1} ...`
-        : `+ ${num_selected} ...`;
+        ? `+ ${num_selected - num_shown - 1} ...`
+        : `+ ${num_selected - num_shown} ...`;
     };
 
     return (