[SPARK-11673][SQL] Remove the normal Project physical operator (and keep TungstenProject) #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,6 +176,22 @@ case class Invoke( | |||
| } | |||
| } | |||
|
|
|||
| case class SerializeUsingKryo(child: Expression) extends UnaryExpression { | |||
There was a problem hiding this comment.
i need to revert this change
|
cc @davies |
|
Test build #45684 has finished for PR 9643 at commit
|
…eep TungstenProject) Also make full outer join being able to produce UnsafeRows.
|
Test build #45706 has finished for PR 9643 at commit
|
|
should we also remove the |
|
Test build #2048 has finished for PR 9643 at commit
|
|
I think so, but usually I find it easier to remove stuff incrementally (due to breaking tests). |
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2015
…eep TungstenProject) Also make full outer join being able to produce UnsafeRows. Author: Reynold Xin <[email protected]> Closes #9643 from rxin/SPARK-11673. (cherry picked from commit 30e7433) Signed-off-by: Reynold Xin <[email protected]>
|
Oops - did anybody review this? I've already merged it. Can somebody take a closer look. Thanks. |
|
@cloud-fan I think we should keep |
|
looks good to me |
|
LGTM |
1 similar comment
|
LGTM |
dskrvk
pushed a commit
to dskrvk/spark
that referenced
this pull request
Nov 13, 2015
…eep TungstenProject) Also make full outer join being able to produce UnsafeRows. Author: Reynold Xin <[email protected]> Closes apache#9643 from rxin/SPARK-11673.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make full outer join being able to produce UnsafeRows.