Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-11485][SQL] Make DataFrameHolder and DatasetHolder public. #9445

Closed
wants to merge 3 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Nov 3, 2015

These two classes should be public, since they are used in public code.

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44957 has finished for PR 9445 at commit ff07bad.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #44960 has finished for PR 9445 at commit f623c5d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class ExecutorLostFailure(\n

@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #44979 has finished for PR 9445 at commit f75c4a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Nov 4, 2015

cc @marmbrus

@@ -52,6 +52,10 @@ abstract class SQLImplicits {
DatasetHolder(_sqlContext.createDataset(rdd))
}

/**
* Creates a [[Dataset]] from a local Seq of Product.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right, we also support Seq of Int. Maybe just say "a local Seq"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #45009 has finished for PR 9445 at commit a14ed6c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class ExecutorLostFailure(\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n * case class DecimalLit(chars: String) extends Token\n * case class UnresolvedStar(target: Option[Seq[String]]) extends Star with Unevaluable\n * case class Exchange(\n * class CoalescedPartitioner(val parent: Partitioner, val partitionStartIndices: Array[Int])\n

@yhuai
Copy link
Contributor

yhuai commented Nov 4, 2015

test this please

@yhuai
Copy link
Contributor

yhuai commented Nov 4, 2015

LGTM

@rxin
Copy link
Contributor Author

rxin commented Nov 4, 2015

Merging this.

@asfgit asfgit closed this in cd1df66 Nov 4, 2015
@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #1979 has finished for PR 9445 at commit a14ed6c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants