-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11485][SQL] Make DataFrameHolder and DatasetHolder public. #9445
Conversation
Test build #44957 has finished for PR 9445 at commit
|
Test build #44960 has finished for PR 9445 at commit
|
Test build #44979 has finished for PR 9445 at commit
|
cc @marmbrus |
@@ -52,6 +52,10 @@ abstract class SQLImplicits { | |||
DatasetHolder(_sqlContext.createDataset(rdd)) | |||
} | |||
|
|||
/** | |||
* Creates a [[Dataset]] from a local Seq of Product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right, we also support Seq of Int. Maybe just say "a local Seq"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Test build #45009 has finished for PR 9445 at commit
|
test this please |
LGTM |
Merging this. |
Test build #1979 has finished for PR 9445 at commit
|
These two classes should be public, since they are used in public code.