Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10516][ MLlib]Added values property in DenseVector #8682

Closed
wants to merge 2 commits into from
Closed

[SPARK-10516][ MLlib]Added values property in DenseVector #8682

wants to merge 2 commits into from

Conversation

vinodkc
Copy link
Contributor

@vinodkc vinodkc commented Sep 10, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Sep 10, 2015

Test build #42238 has finished for PR 8682 at commit b8e1e6e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Sep 14, 2015

We should add it as a @property method instead of a field. Otherwise, it might introduce overhead with serialization.

@SparkQA
Copy link

SparkQA commented Sep 16, 2015

Test build #42525 has finished for PR 8682 at commit b77e420.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 95b6a81 Sep 16, 2015
@mengxr
Copy link
Contributor

mengxr commented Sep 16, 2015

LGTM. Merged into master. @vinodkc values needs API doc, alone with some other public methods. I created a JIRA for it: https://issues.apache.org/jira/browse/SPARK-10631. Could you help add them? Thanks!

@vinodkc
Copy link
Contributor Author

vinodkc commented Sep 16, 2015

Sure I'll work on SPARK-10631
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinodkc @SparkQA @mengxr