Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8998][MLlib] Distribute PrefixSpan computation for large projected databases #7783

Closed

Conversation

feynmanliang
Copy link
Contributor

Continuation of work by @zhangjiajin

Closes #7412

zhangjiajin and others added 30 commits July 7, 2015 15:30
Use PrefixSpan.scala instead of Prefixspan.scala. Delete Prefixspan.scala
Use PrefixSpanSuite.scala instead of PrefixspanSuite.scala, Delete PrefixspanSuite.scala.
[Spark-8998]Collect Enough Prefixes Improvements
@feynmanliang
Copy link
Contributor Author

@mengxr I've made the lineage changes as requested, but have concerns about the scalability of these changes. See in-line comments.

My preference is to prefer the longer lineage chain over the potential lack of scalability introduced by these changes.

pairsForDistributed = largerPairsPart
pairsForDistributed.persist(StorageLevel.MEMORY_AND_DISK)
pairsForLocal ++= smallerPairsPart
resultsAccumulator ++= nextPatternAndCounts.collect()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause all results except for those generated from pairsForLocal to be collected to driver since we continue processing until pairsForDistributed is empty.

Could potentially be many times the size of the dataset since a length k sequence has up to 2^k subsequences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the worst case. We should assume that the number of frequent patterns are small. Having 1 billion frequent patterns doesn't provide any useful insights. So users should start with a high minSupport and collect just-enough number of frequent patterns.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39000 has finished for PR 7783 at commit 4ddf479.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@feynmanliang
Copy link
Contributor Author

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39004 has finished for PR 7783 at commit a61943d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39010 has finished for PR 7783 at commit a61943d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #158 has finished for PR 7783 at commit a61943d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Jul 30, 2015

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in d212a31 Jul 30, 2015
@feynmanliang feynmanliang deleted the SPARK-8998-improve-distributed branch August 17, 2015 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants