Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-9198] [mllib] [python] Fixed typo in pyspark sparsevector doc tests #7541

Closed
wants to merge 2 commits into from
Closed

[SPARK-9198] [mllib] [python] Fixed typo in pyspark sparsevector doc tests #7541

wants to merge 2 commits into from

Conversation

jkbradley
Copy link
Member

Several places in the PySpark SparseVector docs have one defined as:

SparseVector(4, [2, 4], [1.0, 2.0])

The index 4 goes out of bounds (but this is not checked).

CC: @mengxr

@SparkQA
Copy link

SparkQA commented Jul 20, 2015

Test build #37849 has finished for PR 7541 at commit e2dcb23.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Nondeterministic
    • abstract class RDG extends LeafExpression with Nondeterministic
    • case class Rand(seed: Long) extends RDG
    • case class Randn(seed: Long) extends RDG

@SparkQA
Copy link

SparkQA commented Jul 20, 2015

Test build #37850 has finished for PR 7541 at commit c806a65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Nondeterministic
    • abstract class RDG extends LeafExpression with Nondeterministic
    • case class Rand(seed: Long) extends RDG
    • case class Randn(seed: Long) extends RDG

@feynmanliang
Copy link
Contributor

LGTM

asfgit pushed a commit that referenced this pull request Jul 20, 2015
@jkbradley @mengxr
[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
a57d9a2 
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Jul 20, 2015
@jkbradley @mengxr
[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
c8b17da 
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Jul 20, 2015
@jkbradley @mengxr
[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
429eedd 
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in a5d0581 Jul 20, 2015
asfgit pushed a commit that referenced this pull request Jul 20, 2015
@jkbradley @mengxr
[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
326988e 
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Jul 20, 2015
@jkbradley @mengxr
[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
d304ef4 
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Jul 20, 2015

Merged into master and all branches since 1.0. Thanks!

@jkbradley jkbradley deleted the sparsevec-doc-typo-fix branch July 21, 2015 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkbradley @SparkQA @feynmanliang @mengxr