[Spark-7179][SQL]add tablenamepattern to hive sql of "show tables" #6745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ private[sql] class SparkSQLParser(fallback: String => LogicalPlan) extends Abstr | |||
| protected val TABLES = Keyword("TABLES") | |||
| protected val UNCACHE = Keyword("UNCACHE") | |||
|
|
|||
| override protected lazy val start: Parser[LogicalPlan] = cache | uncache | set | show | others | |||
| override protected lazy val start: Parser[LogicalPlan] = cache ||| uncache ||| set ||| show ||| others | |||
|
Test build #34597 has finished for PR 6745 at commit
|
|
|
||
| private lazy val showInHive: Parser[LogicalPlan] = | ||
| SHOW ~ TABLES ~> (IN ~> ident).? ~ opt(stringLit) ^^ { | ||
| case dbName ~ reg => ShowTablesCommand(dbName, reg) |
There was a problem hiding this comment.
Nit: Please rename reg to regexPattern.
|
This change generally looks good except for some styling issues. Thanks for working on this! |
|
@liancheng thank you for review this PR, had modify the style :) |
|
Test build #34661 has finished for PR 6745 at commit
|
|
Test build #34667 has finished for PR 6745 at commit
|
|
@baishuo @liancheng any updates on this? Is this patch still active? |
|
hi @andrewor14 @liancheng , This patch didnt pass some test. And I didnt find way to resolve it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the whole hive sql grammar of "show tables " is like "show tables [in databasename] [tablenamepattern]", "show tables [in databasename]" is already implement at spark sql component, and this PR implement "show tables [in databasename] tablenamepattern" at spark hive component