[Spark-8043][MLlib][Doc] update NaiveBayes and SVM examples in doc #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #33982 has finished for PR 6584 at commit
|
| @@ -282,8 +277,8 @@ public class SVMClassifier { | |||
| System.out.println("Area under ROC = " + auROC); | |||
|
|
|||
| // Save and load model | |||
| model.save(sc.sc(), "myModelPath"); | |||
| SVMModel sameModel = SVMModel.load(sc.sc(), "myModelPath"); | |||
| model.save(sc, "myModelPath"); | |||
There was a problem hiding this comment.
I think sc.sc() is required because save expects a SparkContext instead of JavaSparkContext. Though we should really overload it with JavaSparkContext.
There was a problem hiding this comment.
Hi Xiangrui, the sc here seems to be an instance of SparkContext (refer to line 251). And the original code has compile error.
There was a problem hiding this comment.
Oh, I see. We only use it in loadLibSVMFile. Thanks for catching this!
|
Test build #34051 has finished for PR 6584 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2015
jira: https://issues.apache.org/jira/browse/SPARK-8043 I found some issues during testing the save/load examples in markdown Documents, as a part of 1.4 QA plan Author: Yuhao Yang <[email protected]> Closes #6584 from hhbyyh/naiveDocExample and squashes the following commits: a01a206 [Yuhao Yang] fix for Gaussian mixture 2fb8b96 [Yuhao Yang] update NaiveBayes and SVM examples in doc (cherry picked from commit 43adbd5) Signed-off-by: Xiangrui Meng <[email protected]>
|
LGTM. Merged into master and branch-1.4. Thanks! |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
jira: https://issues.apache.org/jira/browse/SPARK-8043 I found some issues during testing the save/load examples in markdown Documents, as a part of 1.4 QA plan Author: Yuhao Yang <[email protected]> Closes apache#6584 from hhbyyh/naiveDocExample and squashes the following commits: a01a206 [Yuhao Yang] fix for Gaussian mixture 2fb8b96 [Yuhao Yang] update NaiveBayes and SVM examples in doc
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
jira: https://issues.apache.org/jira/browse/SPARK-8043 I found some issues during testing the save/load examples in markdown Documents, as a part of 1.4 QA plan Author: Yuhao Yang <[email protected]> Closes apache#6584 from hhbyyh/naiveDocExample and squashes the following commits: a01a206 [Yuhao Yang] fix for Gaussian mixture 2fb8b96 [Yuhao Yang] update NaiveBayes and SVM examples in doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/SPARK-8043
I found some issues during testing the save/load examples in markdown Documents, as a part of 1.4 QA plan