[Spark-7949] [MLlib] [Doc] update document with some missing save/load #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #33735 has finished for PR 6498 at commit
|
|
@hhbyyh I don't see any problems. Just to confirm, have you run all of the updated examples? |
|
@jkbradley. Sure, I have verified the changes. |
| @@ -63,6 +63,10 @@ val clusters = KMeans.train(parsedData, numClusters, numIterations) | |||
| val WSSSE = clusters.computeCost(parsedData) | |||
| println("Within Set Sum of Squared Errors = " + WSSSE) | |||
| {% endhighlight %} | |||
|
|
|||
| // Save and load model | |||
There was a problem hiding this comment.
Oops! I missed this before. This should go before the endhighlight.
Also, you now need to import KMeansModel
|
I missed these items on my first pass---and I remember making the same mistakes when I first wrote save/load examples! |
|
@jkbradley This is awkward... Thanks a lot for the careful review. |
|
Test build #33846 has finished for PR 6498 at commit
|
|
No problem (and thanks for catching that other typo I missed). Merging into master and branch-1.4 |
asfgit
pushed a commit
that referenced
this pull request
May 31, 2015
add save load for examples: KMeansModel PowerIterationClusteringModel Word2VecModel IsotonicRegressionModel Author: Yuhao Yang <[email protected]> Closes #6498 from hhbyyh/docSaveLoad and squashes the following commits: 7f9f06d [Yuhao Yang] add missing imports c604cad [Yuhao Yang] Merge remote-tracking branch 'upstream/master' into docSaveLoad 1dd77cc [Yuhao Yang] update document with some missing save/load (cherry picked from commit 0674700) Signed-off-by: Joseph K. Bradley <[email protected]>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
add save load for examples: KMeansModel PowerIterationClusteringModel Word2VecModel IsotonicRegressionModel Author: Yuhao Yang <[email protected]> Closes apache#6498 from hhbyyh/docSaveLoad and squashes the following commits: 7f9f06d [Yuhao Yang] add missing imports c604cad [Yuhao Yang] Merge remote-tracking branch 'upstream/master' into docSaveLoad 1dd77cc [Yuhao Yang] update document with some missing save/load
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
add save load for examples: KMeansModel PowerIterationClusteringModel Word2VecModel IsotonicRegressionModel Author: Yuhao Yang <[email protected]> Closes apache#6498 from hhbyyh/docSaveLoad and squashes the following commits: 7f9f06d [Yuhao Yang] add missing imports c604cad [Yuhao Yang] Merge remote-tracking branch 'upstream/master' into docSaveLoad 1dd77cc [Yuhao Yang] update document with some missing save/load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add save load for examples:
KMeansModel
PowerIterationClusteringModel
Word2VecModel
IsotonicRegressionModel