[SPARK-6028][Core]A new RPC implemetation based on the network module #6457

zsxwing · 2015-05-28T15:24:24Z

Design doc: https://docs.google.com/document/d/1CF5G6rGVQMKSyV_QKo4D2M-x6rxz5x1Ew7aK3Uq6u8c/edit?usp=sharing

SparkQA · 2015-05-28T16:38:17Z

Test build #33660 has finished for PR 6457 at commit 2011e94.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(
- class KryoSerializationStream(
- class KryoDeserializationStream(

SparkQA · 2015-05-29T16:51:10Z

Test build #33748 has finished for PR 6457 at commit e41f2e8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(

SparkQA · 2015-05-30T01:22:46Z

Test build #33783 has finished for PR 6457 at commit 91fc944.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(

zsxwing · 2015-05-31T10:13:57Z

retest this please

SparkQA · 2015-05-31T10:23:56Z

Test build #33850 has finished for PR 6457 at commit 91fc944.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(

SparkQA · 2015-05-31T13:48:43Z

Test build #33852 has finished for PR 6457 at commit 64f1f04.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(
- case class SortOrder(child: Expression, direction: SortDirection) extends Expression
- abstract class BinaryMathExpression(f: (Double, Double) => Double, name: String)

SparkQA · 2015-05-31T15:54:17Z

Test build #33854 has finished for PR 6457 at commit 879ecd5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(

SparkQA · 2015-06-06T17:43:15Z

Test build #34367 timed out for PR 6457 at commit 1735f2d after a configured wait of 175m.

SparkQA · 2015-06-08T17:53:35Z

Test build #34450 has finished for PR 6457 at commit 019334a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class MessageLoop extends Runnable
- class NettyRpcEnvFactory extends RpcEnvFactory with Logging
- class NettyRpcEndpointRef(@transient conf: SparkConf)
- class NettyRpcHandler(

SparkQA · 2015-06-24T16:51:34Z

Test build #35687 has finished for PR 6457 at commit 24aea28.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

rxin · 2015-07-21T19:47:40Z

@zsxwing can you bring this up to date? I'd like to review this this week.

SparkQA · 2015-07-22T19:29:35Z

Test build #38094 has finished for PR 6457 at commit f905c72.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

zsxwing · 2015-07-23T02:02:03Z

retest this please

SparkQA · 2015-07-23T03:51:03Z

Test build #38146 has finished for PR 6457 at commit f905c72.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2015-07-23T03:57:11Z

Test build #68 has finished for PR 6457 at commit f905c72.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2015-07-23T16:49:06Z

core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala

+  def registerRpcEndpoint(name: String, endpoint: RpcEndpoint): NettyRpcEndpointRef = {
+    val addr = new NettyRpcAddress(nettyEnv.address.host, nettyEnv.address.port, name)
+    val endpointRef = new NettyRpcEndpointRef(nettyEnv.conf, addr, nettyEnv)
+    nameToEndpoint.put(name, new RpcEndpointPair(endpoint, endpointRef))


Should this check whether name is already being used? Just in case.

vanzin · 2015-09-21T22:42:20Z

core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala

+
+  private val clientConnectionExecutor = ThreadUtils.newDaemonCachedThreadPool(
+    "netty-rpc-connection",
+    conf.getInt("spark.rpc.connect.threads", 256))


This looks a bit excessive, but then it kinda sucks that TransportClientFactory.createClient is blocking. Perhaps we should write that down as a future enhancement.

vanzin · 2015-09-21T23:09:27Z

Left some minor feedback. After those are taken care of, this LGTM. @rxin did you mean to also take a look at this?

rxin · 2015-09-21T23:11:05Z

Will take a look later. But given it is early in the release cycle & size of the patch, I'm also ok with merging it first and do post-hoc reviews & feedback addressing later.

…ask'

SparkQA · 2015-09-22T04:55:29Z

Test build #42806 has finished for PR 6457 at commit 1c1ec99.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2015-09-22T17:36:48Z

core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala

+
+              override def onSuccess(response: Array[Byte]): Unit = {
+                val reply = deserialize[AskResponse](response)
+                if (reply.reply != null && reply.reply.isInstanceOf[RpcFailure]) {


nit: null check is redundant.

vanzin · 2015-09-22T17:45:47Z

LGTM; the duplicate event issue is very minor and doesn't happen with the default config (where connections per peer is 1), so not super critical to fix now.

SparkQA · 2015-09-23T02:52:46Z

Test build #42872 has finished for PR 6457 at commit 90de095.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2015-09-23T21:33:51Z

@zsxwing did you intend to leave "netty" as the default rpc implementation? Just double checking. Let me know and I'll merge this.

zsxwing · 2015-09-24T01:57:18Z

@zsxwing did you intend to leave "netty" as the default rpc implementation? Just double checking. Let me know and I'll merge this.

Yes. Actually it's better to use netty now so as to test it and see if it's stable. We can change it to akka if we find any critical issue before releasing it.

rxin · 2015-09-24T01:59:32Z

I'm going to merge this and review it post-hoc.

mengxr · 2015-09-24T15:13:46Z

@zsxwing @rxin I saw this test failure on Jenkins master. If this happens frequently, we may need to revert this patch. I created https://issues.apache.org/jira/browse/SPARK-10799 for the issue.

https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/3596/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.2,label=spark-test/testReport/junit/org.apache.spark.rpc.netty/InboxSuite/post__multiple_threads/

org.apache.spark.rpc.netty.InboxSuite.post: multiple threads

Failing for the past 1 build (Since Failed#3596 )
Took 9 ms.
add description
Error Message

org.apache.spark.rpc.netty.InboxSuite$$anonfun$3$$anon$1@73986812 was not empty
Stacktrace

sbt.ForkMain$ForkError: org.apache.spark.rpc.netty.InboxSuite$$anonfun$3$$anon$1@73986812 was not empty
    at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
    at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
    at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)
    at org.apache.spark.rpc.netty.InboxSuite$$anonfun$3.apply$mcV$sp(InboxSuite.scala:94)
    at org.apache.spark.rpc.netty.InboxSuite$$anonfun$3.apply(InboxSuite.scala:66)
    at org.apache.spark.rpc.netty.InboxSuite$$anonfun$3.apply(InboxSuite.scala:66)
    at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
    at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
    at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
    at org.scalatest.Transformer.apply(Transformer.scala:22)
    at org.scalatest.Transformer.apply(Transformer.scala:20)
    at org.scalatest.FunSuiteLike$$anon$1.apply(FunSuiteLike.scala:166)
    at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:42)
    at org.scalatest.FunSuiteLike$class.invokeWithFixture$1(FunSuiteLike.scala:163)
    at org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)
    at org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)
    at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
    at org.scalatest.FunSuiteLike$class.runTest(FunSuiteLike.scala:175)
    at org.scalatest.FunSuite.runTest(FunSuite.scala:1555)
    at org.scalatest.FunSuiteLike$$anonfun$runTests$1.apply(FunSuiteLike.scala:208)
    at org.scalatest.FunSuiteLike$$anonfun$runTests$1.apply(FunSuiteLike.scala:208)
    at org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:413)
    at org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:401)
    at scala.collection.immutable.List.foreach(List.scala:318)
    at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
    at org.scalatest.SuperEngine.org$scalatest$SuperEngine$$runTestsInBranch(Engine.scala:396)
    at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:483)
    at org.scalatest.FunSuiteLike$class.runTests(FunSuiteLike.scala:208)
    at org.scalatest.FunSuite.runTests(FunSuite.scala:1555)
    at org.scalatest.Suite$class.run(Suite.scala:1424)
    at org.scalatest.FunSuite.org$scalatest$FunSuiteLike$$super$run(FunSuite.scala:1555)
    at org.scalatest.FunSuiteLike$$anonfun$run$1.apply(FunSuiteLike.scala:212)
    at org.scalatest.FunSuiteLike$$anonfun$run$1.apply(FunSuiteLike.scala:212)
    at org.scalatest.SuperEngine.runImpl(Engine.scala:545)
    at org.scalatest.FunSuiteLike$class.run(FunSuiteLike.scala:212)
    at org.scalatest.FunSuite.run(FunSuite.scala:1555)
    at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:462)
    at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:671)
    at sbt.ForkMain$Run$2.call(ForkMain.java:294)
    at sbt.ForkMain$Run$2.call(ForkMain.java:284)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)

mengxr · 2015-09-24T15:18:46Z

Also this might be related: org.apache.spark.deploy.StandaloneDynamicAllocationSuite (https://issues.apache.org/jira/browse/SPARK-10800).

https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/3622/HADOOP_PROFILE=hadoop-2.4,label=spark-test/testReport/junit/org.apache.spark.deploy/

org.apache.spark.deploy.StandaloneDynamicAllocationSuite.dynamic allocation default behavior

Failing for the past 1 build (Since Failed#3622 )
Took 0.12 sec.
add description
Error Message

1 did not equal 2
Stacktrace

      org.scalatest.exceptions.TestFailedException: 1 did not equal 2
      at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
      at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
      at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite$$anonfun$1.apply$mcV$sp(StandaloneDynamicAllocationSuite.scala:78)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite$$anonfun$1.apply(StandaloneDynamicAllocationSuite.scala:73)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite$$anonfun$1.apply(StandaloneDynamicAllocationSuite.scala:73)
      at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
      at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
      at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
      at org.scalatest.Transformer.apply(Transformer.scala:22)
      at org.scalatest.Transformer.apply(Transformer.scala:20)
      at org.scalatest.FunSuiteLike$$anon$1.apply(FunSuiteLike.scala:166)
      at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:42)
      at org.scalatest.FunSuiteLike$class.invokeWithFixture$1(FunSuiteLike.scala:163)
      at org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)
      at org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)
      at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
      at org.scalatest.FunSuiteLike$class.runTest(FunSuiteLike.scala:175)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite.org$scalatest$BeforeAndAfterEach$$super$runTest(StandaloneDynamicAllocationSuite.scala:33)
      at org.scalatest.BeforeAndAfterEach$class.runTest(BeforeAndAfterEach.scala:255)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite.runTest(StandaloneDynamicAllocationSuite.scala:33)
      at org.scalatest.FunSuiteLike$$anonfun$runTests$1.apply(FunSuiteLike.scala:208)
      at org.scalatest.FunSuiteLike$$anonfun$runTests$1.apply(FunSuiteLike.scala:208)
      at org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:413)
      at org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:401)
      at scala.collection.immutable.List.foreach(List.scala:318)
      at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
      at org.scalatest.SuperEngine.org$scalatest$SuperEngine$$runTestsInBranch(Engine.scala:396)
      at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:483)
      at org.scalatest.FunSuiteLike$class.runTests(FunSuiteLike.scala:208)
      at org.scalatest.FunSuite.runTests(FunSuite.scala:1555)
      at org.scalatest.Suite$class.run(Suite.scala:1424)
      at org.scalatest.FunSuite.org$scalatest$FunSuiteLike$$super$run(FunSuite.scala:1555)
      at org.scalatest.FunSuiteLike$$anonfun$run$1.apply(FunSuiteLike.scala:212)
      at org.scalatest.FunSuiteLike$$anonfun$run$1.apply(FunSuiteLike.scala:212)
      at org.scalatest.SuperEngine.runImpl(Engine.scala:545)
      at org.scalatest.FunSuiteLike$class.run(FunSuiteLike.scala:212)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite.org$scalatest$BeforeAndAfterAll$$super$run(StandaloneDynamicAllocationSuite.scala:33)
      at org.scalatest.BeforeAndAfterAll$class.liftedTree1$1(BeforeAndAfterAll.scala:257)
      at org.scalatest.BeforeAndAfterAll$class.run(BeforeAndAfterAll.scala:256)
      at org.apache.spark.deploy.StandaloneDynamicAllocationSuite.run(StandaloneDynamicAllocationSuite.scala:33)
      at org.scalatest.Suite$class.callExecuteOnSuite$1(Suite.scala:1492)
      at org.scalatest.Suite$$anonfun$runNestedSuites$1.apply(Suite.scala:1528)
      at org.scalatest.Suite$$anonfun$runNestedSuites$1.apply(Suite.scala:1526)
      at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
      at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:108)
      at org.scalatest.Suite$class.runNestedSuites(Suite.scala:1526)
      at org.scalatest.tools.DiscoverySuite.runNestedSuites(DiscoverySuite.scala:29)
      at org.scalatest.Suite$class.run(Suite.scala:1421)
      at org.scalatest.tools.DiscoverySuite.run(DiscoverySuite.scala:29)
      at org.scalatest.tools.SuiteRunner.run(SuiteRunner.scala:55)
      at org.scalatest.tools.Runner$$anonfun$doRunRunRunDaDoRunRun$3.apply(Runner.scala:2563)
      at org.scalatest.tools.Runner$$anonfun$doRunRunRunDaDoRunRun$3.apply(Runner.scala:2557)
      at scala.collection.immutable.List.foreach(List.scala:318)
      at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:2557)
      at org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1044)
      at org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1043)
      at org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:2722)
      at org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:1043)
      at org.scalatest.tools.Runner$.main(Runner.scala:860)
      at org.scalatest.tools.Runner.main(Runner.scala)

zsxwing · 2015-09-24T15:23:48Z

@zsxwing @rxin I saw this test failure on Jenkins master. If this happens frequently, we may need to revert this patch. I created https://issues.apache.org/jira/browse/SPARK-10799 for the issue.

I have already sent #8905 to fix this test

mengxr · 2015-09-24T15:26:51Z

Actually, the second is worse, which broke most recent master builds.

mengxr · 2015-09-24T15:32:10Z

@zsxwing I reverted this patch due to master build failures. Please fix the tests and re-submit a PR. Thanks!

https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/Spark-Master-Maven-pre-YARN/4232/HADOOP_VERSION=2.0.0-mr1-cdh4.1.2,label=spark-test/testReport/junit/org.apache.spark.deploy/StandaloneDynamicAllocationSuite/dynamic_allocation_default_behavior/history/

zsxwing · 2015-09-24T16:17:27Z

@mengxr I saw some race conditions in StandaloneDynamicAllocationSuite after reviewing it. This patch just exposed them. I'm thinking about how to fix them. It's better to remerge this patch after fixing StandaloneDynamicAllocationSuite to avoid breaking the master branch.

zsxwing · 2015-09-25T02:09:13Z

Just realized we don't need to revert it. The new RPC can be disabled...

…#8905 This PR just reverted 02144d6 to remerge #6457 and also included the commits in #8905. Author: zsxwing <[email protected]> Closes #8944 from zsxwing/SPARK-6028.

zsxwing added 2 commits May 31, 2015 20:14

A new RPC implemetation based on the network module

38acc15

Fix InboxSuite

caff122

zsxwing mentioned this pull request Jun 1, 2015

[SPARK-7989][Core][Tests] Fix flaky tests in ExternalShuffleServiceSuite and SparkListenerWithClusterSuite #6546

Closed

zsxwing added 2 commits June 6, 2015 22:36

Fix the code style

02fbca0

Merge branch 'master' into new-rpc

1735f2d

ThreadSafeInbox and ConcurrentInbox

019334a

zsxwing added 2 commits June 24, 2015 09:49

Make new classes private

c8acb8a

Merge branch 'master' into new-rpc

24aea28

zsxwing changed the title ~~[SPARK-6028][Core][WIP] A new RPC implemetation based on the network module~~ [SPARK-6028][Core]A new RPC implemetation based on the network module Jun 29, 2015

Merge branch 'master' into new-rpc

456d314

zsxwing mentioned this pull request Jul 2, 2015

[SPARK-6980] [CORE] Akka timeout exceptions indicate which conf controls them (RPC Layer) #6205

Closed

Merge branch 'master' into new-rpc

f905c72

vanzin reviewed Jul 23, 2015
View reviewed changes

vanzin reviewed Sep 21, 2015
View reviewed changes

zsxwing added 4 commits September 22, 2015 09:23

Use JavaSerializerInstance in the constructor insead of JavaSerializer

9077068

Use clientConnectionExecutor to run the blocking 'createClient' for '…

610d155

…ask'

ssl -> authentication

b998ec1

Add more comments to RpcEndpoint.onStop and fix onDrop

1c1ec99

vanzin reviewed Sep 22, 2015
View reviewed changes

Remove null check

90de095

asfgit closed this in 084e4e1 Sep 24, 2015

zsxwing mentioned this pull request Sep 24, 2015

[SPARK-10799][Core]Fix InboxSuite 'post: multiple threads' #8905

Closed

This was referenced Sep 25, 2015

[SPARK-10825][Core][Tests]Fix race conditions in StandaloneDynamicAllocationSuite #8914

Closed

[SPARK-6028][Core]Remerge #6457: new RPC implemetation and also pick #8905 #8944

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-6028][Core]A new RPC implemetation based on the network module #6457

[SPARK-6028][Core]A new RPC implemetation based on the network module #6457

zsxwing commented May 28, 2015

SparkQA commented May 28, 2015

SparkQA commented May 29, 2015

SparkQA commented May 30, 2015

zsxwing commented May 31, 2015

SparkQA commented May 31, 2015

SparkQA commented May 31, 2015

SparkQA commented May 31, 2015

SparkQA commented Jun 6, 2015

SparkQA commented Jun 8, 2015

SparkQA commented Jun 24, 2015

rxin commented Jul 21, 2015

SparkQA commented Jul 22, 2015

zsxwing commented Jul 23, 2015

SparkQA commented Jul 23, 2015

SparkQA commented Jul 23, 2015

vanzin Jul 23, 2015

vanzin Sep 21, 2015

vanzin commented Sep 21, 2015

rxin commented Sep 21, 2015

SparkQA commented Sep 22, 2015

vanzin Sep 22, 2015

vanzin commented Sep 22, 2015

SparkQA commented Sep 23, 2015

vanzin commented Sep 23, 2015

zsxwing commented Sep 24, 2015

rxin commented Sep 24, 2015

mengxr commented Sep 24, 2015

mengxr commented Sep 24, 2015

zsxwing commented Sep 24, 2015

mengxr commented Sep 24, 2015

mengxr commented Sep 24, 2015

zsxwing commented Sep 24, 2015

zsxwing commented Sep 25, 2015

[SPARK-6028][Core]A new RPC implemetation based on the network module #6457

[SPARK-6028][Core]A new RPC implemetation based on the network module #6457

Conversation

zsxwing commented May 28, 2015

SparkQA commented May 28, 2015

SparkQA commented May 29, 2015

SparkQA commented May 30, 2015

zsxwing commented May 31, 2015

SparkQA commented May 31, 2015

SparkQA commented May 31, 2015

SparkQA commented May 31, 2015

SparkQA commented Jun 6, 2015

SparkQA commented Jun 8, 2015

SparkQA commented Jun 24, 2015

rxin commented Jul 21, 2015

SparkQA commented Jul 22, 2015

zsxwing commented Jul 23, 2015

SparkQA commented Jul 23, 2015

SparkQA commented Jul 23, 2015

vanzin Jul 23, 2015

Choose a reason for hiding this comment

vanzin Sep 21, 2015

Choose a reason for hiding this comment

vanzin commented Sep 21, 2015

rxin commented Sep 21, 2015

SparkQA commented Sep 22, 2015

vanzin Sep 22, 2015

Choose a reason for hiding this comment

vanzin commented Sep 22, 2015

SparkQA commented Sep 23, 2015

vanzin commented Sep 23, 2015

zsxwing commented Sep 24, 2015

rxin commented Sep 24, 2015

mengxr commented Sep 24, 2015

mengxr commented Sep 24, 2015

zsxwing commented Sep 24, 2015

mengxr commented Sep 24, 2015

mengxr commented Sep 24, 2015

zsxwing commented Sep 24, 2015

zsxwing commented Sep 25, 2015