Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-7604] [MLlib] Python API for PCA and PCAModel #6315

Closed
wants to merge 2 commits into from

Conversation

yanboliang
Copy link
Contributor

Python API for PCA and PCAModel

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33231 has finished for PR 6315 at commit 4d9d121.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PCAModel(JavaVectorTransformer):
    • class PCA(object):

:param vector: Vector or RDD of Vector to be transformed.
:return: transformed vector.
"""
return JavaVectorTransformer.transform(self, vector)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default behavior, so you could not have transform() in PCAModel. (just remove transform() here)

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33343 has finished for PR 6315 at commit 1d58734.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PCAModel(JavaVectorTransformer):
    • class PCA(object):

@yanboliang
Copy link
Contributor Author

@jkbradley @mengxr

@jkbradley
Copy link
Member

LGTM sorry for the delay!
I'll rerun tests since it's been a while, before merging

@jkbradley
Copy link
Member

test this please

@SparkQA
Copy link

SparkQA commented Jun 21, 2015

Test build #35403 has finished for PR 6315 at commit 1d58734.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PCAModel(JavaVectorTransformer):
    • class PCA(object):

@jkbradley
Copy link
Member

Merging with master

Thanks!

@asfgit asfgit closed this in 32e3cda Jun 21, 2015
@yanboliang yanboliang deleted the spark-7604 branch June 26, 2015 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants