Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Fix ORC build break #6244

Closed
wants to merge 1 commit into from
Closed

[HOTFIX] Fix ORC build break #6244

wants to merge 1 commit into from

Conversation

marmbrus
Copy link
Contributor

Fix break caused by merging #6225 and #6194.

@vanzin
Copy link
Contributor

vanzin commented May 18, 2015

LGTM.

@andrewor14
Copy link
Contributor

I'm just going to merge this now since master doesn't even compile.

This is going into branches master and 1.4.

@asfgit asfgit closed this in fcf90b7 May 18, 2015
asfgit pushed a commit that referenced this pull request May 18, 2015
@marmbrus
[HOTFIX] Fix ORC build break
ba502ab 
Fix break caused by merging #6225 and #6194.

Author: Michael Armbrust <[email protected]>

Closes #6244 from marmbrus/fixOrcBuildBreak and squashes the following commits:

b10e47b [Michael Armbrust] [HOTFIX] Fix ORC Build break

(cherry picked from commit fcf90b7)
Signed-off-by: Andrew Or <[email protected]>
@JoshRosen
Copy link
Contributor

@marmbrus @andrewor14 , could you also look at #6243, which I think is trying to fix a Maven build break?

@harishreedharan
Copy link
Contributor

I realize that master and thus PR builder is broken, but it would be good to wait for the PR builder to complete before merging.

@marmbrus
Copy link
Contributor Author

I disagree. Failing all PRs for the next two hours is not reasonable. We
can always watch and make sure the tests pass even though this has been
merged.
On May 18, 2015 2:09 PM, "Hari Shreedharan" [email protected]
wrote:

I realize that master and thus PR builder is broken, but it would be good
to wait for the PR builder to complete before merging.

—
Reply to this email directly or view it on GitHub
#6244 (comment).

@andrewor14 andrewor14 mentioned this pull request May 18, 2015
Closed
@andrewor14
Copy link
Contributor

@harishreedharan I think that's reasonable under normal circumstances, but having the PR builder to fail tests on every single patch for the next 2+ hours is very expensive for the process of development across the entire community, especially around release windows. In the worst case merging this now causes the build to fail when it's already failing.

@vanzin vanzin mentioned this pull request May 18, 2015
Closed
@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #33017 has finished for PR 6244 at commit b10e47b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus marmbrus mentioned this pull request May 18, 2015
Closed
@marmbrus
Copy link
Contributor Author

Test failures are addressed in #6247.

asfgit pushed a commit that referenced this pull request May 18, 2015
@marmbrus @yhuai
[SQL] Fix serializability of ORC table scan
f8f23c4 
A follow-up to #6244.

Author: Michael Armbrust <[email protected]>

Closes #6247 from marmbrus/fixOrcTests and squashes the following commits:

e39ee1b [Michael Armbrust] [SQL] Fix serializability of ORC table scan

(cherry picked from commit eb4632f)
Signed-off-by: Yin Huai <[email protected]>
asfgit pushed a commit that referenced this pull request May 18, 2015
@marmbrus @yhuai
[SQL] Fix serializability of ORC table scan
eb4632f 
A follow-up to #6244.

Author: Michael Armbrust <[email protected]>

Closes #6247 from marmbrus/fixOrcTests and squashes the following commits:

e39ee1b [Michael Armbrust] [SQL] Fix serializability of ORC table scan
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@marmbrus @jeanlyn
[HOTFIX] Fix ORC build break
d70ab17 
Fix break caused by merging apache#6225 and apache#6194.

Author: Michael Armbrust <[email protected]>

Closes apache#6244 from marmbrus/fixOrcBuildBreak and squashes the following commits:

b10e47b [Michael Armbrust] [HOTFIX] Fix ORC Build break
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@marmbrus @jeanlyn
[SQL] Fix serializability of ORC table scan
a20f99a 
A follow-up to apache#6244.

Author: Michael Armbrust <[email protected]>

Closes apache#6247 from marmbrus/fixOrcTests and squashes the following commits:

e39ee1b [Michael Armbrust] [SQL] Fix serializability of ORC table scan
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@marmbrus @jeanlyn
[HOTFIX] Fix ORC build break
f95b84e 
Fix break caused by merging apache#6225 and apache#6194.

Author: Michael Armbrust <[email protected]>

Closes apache#6244 from marmbrus/fixOrcBuildBreak and squashes the following commits:

b10e47b [Michael Armbrust] [HOTFIX] Fix ORC Build break
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@marmbrus @jeanlyn
[SQL] Fix serializability of ORC table scan
6d27963 
A follow-up to apache#6244.

Author: Michael Armbrust <[email protected]>

Closes apache#6247 from marmbrus/fixOrcTests and squashes the following commits:

e39ee1b [Michael Armbrust] [SQL] Fix serializability of ORC table scan
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@marmbrus @nemccarthy
[HOTFIX] Fix ORC build break
bfbe438 
Fix break caused by merging apache#6225 and apache#6194.

Author: Michael Armbrust <[email protected]>

Closes apache#6244 from marmbrus/fixOrcBuildBreak and squashes the following commits:

b10e47b [Michael Armbrust] [HOTFIX] Fix ORC Build break
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@marmbrus @nemccarthy
[SQL] Fix serializability of ORC table scan
f631220 
A follow-up to apache#6244.

Author: Michael Armbrust <[email protected]>

Closes apache#6247 from marmbrus/fixOrcTests and squashes the following commits:

e39ee1b [Michael Armbrust] [SQL] Fix serializability of ORC table scan
@marmbrus marmbrus deleted the fixOrcBuildBreak branch August 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marmbrus @vanzin @andrewor14 @JoshRosen @harishreedharan @SparkQA