[SPARK-7036][MLLIB] ALS.train should support DataFrames in PySpark #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #30691 has finished for PR 5619 at commit
|
|
test this please |
| ratings = ratings.rdd | ||
| else: | ||
| raise TypeError("Ratings should be represented by either an RDD or a DataFrame, " | ||
| "but got %s." % type(ratings)) |
There was a problem hiding this comment.
a minor issue: maybe better to use "%s is provided"
|
LGTM. |
|
Test build #30697 has finished for PR 5619 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Apr 21, 2015
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. coderxiang Author: Xiangrui Meng <[email protected]> Closes #5619 from mengxr/SPARK-7036 and squashes the following commits: dfcaf5a [Xiangrui Meng] ALS.train should support DataFrames in PySpark (cherry picked from commit 686dd74) Signed-off-by: Xiangrui Meng <[email protected]>
|
Merged into master and branch-1.3. |
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Apr 23, 2015
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. coderxiang Author: Xiangrui Meng <[email protected]> Closes apache#5619 from mengxr/SPARK-7036 and squashes the following commits: dfcaf5a [Xiangrui Meng] ALS.train should support DataFrames in PySpark (cherry picked from commit 686dd74) Signed-off-by: Xiangrui Meng <[email protected]>
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. coderxiang Author: Xiangrui Meng <[email protected]> Closes apache#5619 from mengxr/SPARK-7036 and squashes the following commits: dfcaf5a [Xiangrui Meng] ALS.train should support DataFrames in PySpark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. @coderxiang