[SPARK-6953] [PySpark] speed up python tests #5605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SPARK-6953] [PySpark] speed up python tests Signed-off-by: Reynold Xin <[email protected]> Conflicts: python/pyspark/streaming/tests.py (cherry picked from commit 21b15f5) Signed-off-by: Reynold Xin <[email protected]>
|
Note that this simply brings #5427 up to date. |
|
Test build #30651 has finished for PR 5605 at commit
|
| @@ -303,7 +309,8 @@ def test_classification(self): | |||
| self.assertEqual(same_dt_model.toDebugString(), dt_model.toDebugString()) | |||
|
|
|||
| rf_model = RandomForest.trainClassifier( | |||
| rdd, numClasses=2, categoricalFeaturesInfo=categoricalFeaturesInfo, numTrees=100) | |||
| rdd, numClasses=2, categoricalFeaturesInfo=categoricalFeaturesInfo, numTrees=10, | |||
| maxBins=4) | |||
| self.assertTrue(rf_model.predict(features[0]) <= 0) | |||
There was a problem hiding this comment.
this line is failing now. is there some non-determinism? @mengxr
There was a problem hiding this comment.
There is, but you can pass "seed" If it's hard to find a good seed, I'd recommend setting featureSubsetStrategy = "all" as well (to eliminate a bit of stochasticity)
|
Sent you a PR at rxin#14. |
fix seed in tests
|
Test build #30704 has finished for PR 5605 at commit
|
|
Jenkins, retest this please. |
|
Test build #30708 has finished for PR 5605 at commit
|
|
I'm going to merge this. |
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This PR try to speed up some python tests: ``` tests.py 144s -> 103s -41s mllib/classification.py 24s -> 17s -7s mllib/regression.py 27s -> 15s -12s mllib/tree.py 27s -> 13s -14s mllib/tests.py 64s -> 31s -33s streaming/tests.py 185s -> 84s -101s ``` Considering python3, the total saving will be 558s (almost 10 minutes) (core, and streaming run three times, mllib runs twice). During testing, it will show used time for each test file: ``` Run core tests ... Running test: pyspark/rdd.py ... ok (22s) Running test: pyspark/context.py ... ok (16s) Running test: pyspark/conf.py ... ok (4s) Running test: pyspark/broadcast.py ... ok (4s) Running test: pyspark/accumulators.py ... ok (4s) Running test: pyspark/serializers.py ... ok (6s) Running test: pyspark/profiler.py ... ok (5s) Running test: pyspark/shuffle.py ... ok (1s) Running test: pyspark/tests.py ... ok (103s) 144s ``` Author: Reynold Xin <[email protected]> Author: Xiangrui Meng <[email protected]> Closes apache#5605 from rxin/python-tests-speed and squashes the following commits: d08542d [Reynold Xin] Merge pull request apache#14 from mengxr/SPARK-6953 89321ee [Xiangrui Meng] fix seed in tests 3ad2387 [Reynold Xin] Merge pull request apache#5427 from davies/python_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to speed up some python tests:
Considering python3, the total saving will be 558s (almost 10 minutes) (core, and streaming run three times, mllib runs twice).
During testing, it will show used time for each test file: