Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6409][SQL] It is not necessary that avoid old inteface of hive, because this will make some UDAF can not work. #5131

Closed
wants to merge 7 commits into from
Closed

[SPARK-6409][SQL] It is not necessary that avoid old inteface of hive, because this will make some UDAF can not work. #5131

wants to merge 7 commits into from

Conversation

pzzs
Copy link
Contributor

@pzzs pzzs commented Mar 23, 2015

spark avoid old inteface of hive, then some udaf can not work like "org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage"

@pzzs pzzs changed the title [SPARK-6049][SQL] It is not necessary that avoid old inteface of hive, because this will make some UDAF can not work. [SPARK-6409][SQL] It is not necessary that avoid old inteface of hive, because this will make some UDAF can not work. Mar 23, 2015
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29072 has started for PR 5131 at commit 49c62dc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29072 has finished for PR 5131 at commit 49c62dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29072/
Test PASSed.

@marmbrus
Copy link
Contributor

Are there any built-in functions that we could use to write a test case?

@pzzs
Copy link
Contributor Author

pzzs commented Mar 25, 2015

I have added a test for it @marmbrus

@SparkQA
Copy link

SparkQA commented Mar 25, 2015

Test build #29158 has started for PR 5131 at commit 9de08d0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 25, 2015

Test build #29158 has finished for PR 5131 at commit 9de08d0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29158/
Test PASSed.

@marmbrus
Copy link
Contributor

Awesome, thanks for fixing this :)

Merging to master and 1.3!

asfgit pushed a commit that referenced this pull request Mar 25, 2015
@pzzs @marmbrus
[SPARK-6409][SQL] It is not necessary that avoid old inteface of hive…
4efa6c5 
…, because this will make some UDAF can not work.

spark avoid old inteface of hive, then some udaf can not work like "org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage"

Author: DoingDone9 <[email protected]>

Closes #5131 from DoingDone9/udaf and squashes the following commits:

9de08d0 [DoingDone9] Update HiveUdfSuite.scala
49c62dc [DoingDone9] Update hiveUdfs.scala
98b134f [DoingDone9] Merge pull request #5 from apache/master
161cae3 [DoingDone9] Merge pull request #4 from apache/master
c87e8b6 [DoingDone9] Merge pull request #3 from apache/master
cb1852d [DoingDone9] Merge pull request #2 from apache/master
c3f046f [DoingDone9] Merge pull request #1 from apache/master

(cherry picked from commit 968408b)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 968408b Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pzzs @AmplabJenkins @marmbrus @SparkQA