Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6421][MLLIB] _regression_train_wrapper does not test initialWeights correctly #5101

Closed
wants to merge 2 commits into from
Closed

[SPARK-6421][MLLIB] _regression_train_wrapper does not test initialWeights correctly #5101

wants to merge 2 commits into from

Conversation

Lewuathe
Copy link
Contributor

Weight parameters must be initialized correctly even when numpy array is passed as initial weights.

@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28911 has started for PR 5101 at commit 21d4fe3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28911 has finished for PR 5101 at commit 21d4fe3.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class TaskCommitDenied(jobID: Int, partitionID: Int, attemptID: Int) extends TaskFailedReason
    • class ExecutorSource(threadPool: ThreadPoolExecutor, executorId: String) extends Source

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28911/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28913 has started for PR 5101 at commit 7795201.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28913 has finished for PR 5101 at commit 7795201.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28913/
Test PASSed.

asfgit pushed a commit that referenced this pull request Mar 20, 2015
@Lewuathe @mengxr
[SPARK-6421][MLLIB] _regression_train_wrapper does not test initialWe…
aff9f8d 
…ights correctly

Weight parameters must be initialized correctly even when numpy array is passed as initial weights.

Author: lewuathe <[email protected]>

Closes #5101 from Lewuathe/SPARK-6421 and squashes the following commits:

7795201 [lewuathe] Fix lint-python errors
21d4fe3 [lewuathe] Fix init logic of weights

(cherry picked from commit 257cde7)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Mar 20, 2015

LGTM. Merged into master and branch-1.3. Thanks!

@asfgit asfgit closed this in 257cde7 Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lewuathe @SparkQA @AmplabJenkins @mengxr