[SPARK-50381][CORE] Support spark.master.rest.maxThreads
#48921
Closed
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-50381
branch
from
89bb138
to
0395de1
Compare
dongjoon-hyun
force-pushed
the
SPARK-50381
branch
from
0395de1
to
3b8bde2
Compare
|
The newly added UT passed already in the CIs. |
dongjoon-hyun
commented
Nov 21, 2024
| .doc("Maximum number of threads to use in the Spark Master REST API Server.") | ||
| .version("4.0.0") | ||
| .intConf | ||
| .createWithDefault(200) |
There was a problem hiding this comment.
The default value is identical with the previously-used Jetty's default value.
viirya
approved these changes
Nov 21, 2024
|
Thank you, @viirya ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
spark.master.rest.maxThreads.Why are the changes needed?
To provide users a way to control the number of maximum threads of REST API. Previously, Apache Spark uses a default constructor whose value is fixed to
200always.spark/core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala
Line 94 in 2e1c3dc
https://github.com/jetty/jetty.project/blob/5dfc59a691b748796f922208956bd1f2794bcd16/jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java#L118-L121
Does this PR introduce any user-facing change?
No, the default value of new configuration is identical with the previously-used Jetty's default value.
How was this patch tested?
Pass the CIs with a newly added test case.
Was this patch authored or co-authored using generative AI tooling?
No.