[SPARK-50299][BUILD] Upgrade jupiter-interface to 0.13.1 and Junit5 to 5.11.3 #48834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
LuciferYang
changed the title
LuciferYang
changed the title
LuciferYang
changed the title
LuciferYang
commented
Nov 13, 2024
| @@ -1714,7 +1714,7 @@ object TestSettings { | |||
| (Test / testOptions) += Tests.Argument(TestFrameworks.ScalaTest, "-W", "120", "300"), | |||
| (Test / testOptions) += Tests.Argument(TestFrameworks.JUnit, "-v", "-a"), | |||
| // Enable Junit testing. | |||
| libraryDependencies += "net.aichler" % "jupiter-interface" % "0.11.1" % "test", | |||
| libraryDependencies += "com.github.sbt.junit" % "jupiter-interface" % "0.13.1" % "test", | |||
There was a problem hiding this comment.
This part was missed during the previous upgrade
There was a problem hiding this comment.
Thank you very much for helping to fix it!
Additionally, can we replace this hard coded version parameter with SbtPomKeys.effectivePom.value.getProperties.get("sbt-jupiter-interface.version").asInstanceOf[String]? So next time if we only upgrade the version (without involving groupId or artifactId changes), we only need to update one place.
|
cc @dongjoon-hyun and @panbingkun |
dongjoon-hyun
approved these changes
Nov 14, 2024
|
Thanks @dongjoon-hyun ~ |
|
+1, late LGTM |
|
Thanks @panbingkun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to upgrade
jupiter-interfacefrom 0.13.0 to 0.13.1 and Junit5 to the latest version（Platform 1.11.3 + Jupiter 5.11.3）.Why are the changes needed?
The new version of
jupiter-interfacebrings two fixes:definedTestsin terms of the task itself sbt/sbt-jupiter-interface#116Simultaneously upgraded Junit dependencies to Platform 1.11.3 + Jupiter 5.11.3:
The full release notes of
jupiter-interfaceas follows:and the full release notes between Junit 5.11.0 to 5.11.3 as follows:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No