Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6059][Yarn] Add volatile to ApplicationMaster's reporterThread and allocator #4814

Closed
wants to merge 1 commit into from
Closed

[SPARK-6059][Yarn] Add volatile to ApplicationMaster's reporterThread and allocator #4814

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Feb 27, 2015

ApplicationMaster.reporterThread and ApplicationMaster.allocator are accessed in multiple threads, so they should be marked as volatile.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28063 has started for PR 4814 at commit 17d9386.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Feb 27, 2015

I agree. LGTM pending tests.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28063 has finished for PR 4814 at commit 17d9386.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28063/
Test PASSed.

@srowen
Copy link
Member

srowen commented Feb 27, 2015

I'm going to merge into master only just because it's not clear there is an actual practical issue as a result of this.

@asfgit asfgit closed this in 57566d0 Feb 27, 2015
@zsxwing zsxwing deleted the SPARK-6059 branch February 28, 2015 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsxwing @SparkQA @srowen @AmplabJenkins