[SPARK-49265][SQL][TESTS] Add collation support unit tests for Upper, Lower, and InitCap #47727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
changed the title
uros-db
changed the title
uros-db
commented
Aug 14, 2024
uros-db
changed the title
MaxGekk
approved these changes
Aug 16, 2024
|
+1, LGTM. Merging to master. |
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
… Lower, and InitCap ### What changes were proposed in this pull request? Add collation support unit tests for: - Upper - Lower - InitCap This PR contains test-only changes, providing additional test coverage for cases such as: - case and accent variation - one-to-many case mapping - conditional case mapping - surrogate pairs - etc. ### Why are the changes needed? Improve collation support testing. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New unit tests in `CollationSupportSuite`. ### Was this patch authored or co-authored using generative AI tooling? Yes. Closes apache#47727 from uros-db/unit-tests-3. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
… Lower, and InitCap ### What changes were proposed in this pull request? Add collation support unit tests for: - Upper - Lower - InitCap This PR contains test-only changes, providing additional test coverage for cases such as: - case and accent variation - one-to-many case mapping - conditional case mapping - surrogate pairs - etc. ### Why are the changes needed? Improve collation support testing. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New unit tests in `CollationSupportSuite`. ### Was this patch authored or co-authored using generative AI tooling? Yes. Closes apache#47727 from uros-db/unit-tests-3. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
… Lower, and InitCap ### What changes were proposed in this pull request? Add collation support unit tests for: - Upper - Lower - InitCap This PR contains test-only changes, providing additional test coverage for cases such as: - case and accent variation - one-to-many case mapping - conditional case mapping - surrogate pairs - etc. ### Why are the changes needed? Improve collation support testing. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New unit tests in `CollationSupportSuite`. ### Was this patch authored or co-authored using generative AI tooling? Yes. Closes apache#47727 from uros-db/unit-tests-3. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add collation support unit tests for:
This PR contains test-only changes, providing additional test coverage for cases such as:
Why are the changes needed?
Improve collation support testing.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests in
CollationSupportSuite.Was this patch authored or co-authored using generative AI tooling?
Yes.