-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Minor English fixes #45461
Closed
Closed
[MINOR] Minor English fixes #45461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Mar 11, 2024
I think the test failure is related:
|
xinrong-meng
approved these changes
Mar 12, 2024
LGTM after fixing the test, thanks! |
MaxGekk
approved these changes
Mar 12, 2024
Ah, the test failure is due to the generated error documentation that is checked in to git. #44971 will eliminate this kind of maintenance headache. (Also, look at that diff count. Just beautiful.) That PR is unfortunately blocked by the pending discussion in SPARK-46810. |
thanks, merged to master |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? Minor English grammar and wording fixes. ### Why are the changes needed? They're not strictly needed, but give the project a tiny bit more polish. ### Does this PR introduce _any_ user-facing change? Yes, some user-facing errors have been tweaked. ### How was this patch tested? No testing beyond CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45461 from nchammas/minor-wording-tweaks. Authored-by: Nicholas Chammas <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor English grammar and wording fixes.
Why are the changes needed?
They're not strictly needed, but give the project a tiny bit more polish.
Does this PR introduce any user-facing change?
Yes, some user-facing errors have been tweaked.
How was this patch tested?
No testing beyond CI.
Was this patch authored or co-authored using generative AI tooling?
No.