[SPARK-46596][CORE][TESTS] Correct package name of SslTestUtils
#44596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jan 4, 2024
| @@ -15,8 +15,9 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package org.apache.spark | |||
| package org.apache.spark.util | |||
There was a problem hiding this comment.
cc @dongjoon-hyun FYI
Moving this file to the core/src/test/scala/org/apache/spark/ directory is a solution that involves fewer changes. If you prefer to move the file instead of fixing the package name, please let me know.
There was a problem hiding this comment.
This looks like an incorrect package name - keeping it in util makes more sense.
Thanks for fixing this @LuciferYang !
MaxGekk
approved these changes
Jan 4, 2024
mridulm
approved these changes
Jan 4, 2024
|
The failure https://github.com/LuciferYang/spark/actions/runs/7409548578/job/20163613930 is not related to the changes, and I think it has been fixed by #44594. Let me merge this. |
|
+1, LGTM. Merging to master. |
|
Thanks @MaxGekk @mridulm and @dongjoon-hyun ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The package name for
SslTestUtilsis defined asorg.apache.spark, but it is in theorg/apache/spark/util/directory. This pr corrects its package name to ensure consistency.Why are the changes needed?
Correct package name of
SslTestUtilsDoes this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No