Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild routing table after Graph.reverse #431

Closed
wants to merge 1 commit into from

Conversation

ankurdave
Copy link
Contributor

GraphImpl.reverse used to reverse edges in each partition of the edge RDD but preserve the routing table and replicated vertex view, since reversing should not affect partitioning.

However, the old routing table would then have incorrect information for srcAttrOnly and dstAttrOnly. These RDDs should be switched.

A simple fix is for Graph.reverse to rebuild the routing table and replicated vertex view.

Thanks to Bogdan Ghidireac for reporting this issue on the mailing list.

GraphImpl.reverse used to reverse edges in each partition of the edge
RDD but preserve the routing table and replicated vertex view, since
reversing should not affect partitioning.

However, the old routing table would then have incorrect information for
srcAttrOnly and dstAttrOnly. These RDDs should be switched.

A simple fix is for Graph.reverse to rebuild the routing table and
replicated vertex view.

Thanks to Bogdan Ghidireac for reporting this issue on the mailing list.
@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14187/

@rxin
Copy link
Contributor

rxin commented Apr 17, 2014

lgtm merged.

asfgit pushed a commit that referenced this pull request Apr 17, 2014
GraphImpl.reverse used to reverse edges in each partition of the edge RDD but preserve the routing table and replicated vertex view, since reversing should not affect partitioning.

However, the old routing table would then have incorrect information for srcAttrOnly and dstAttrOnly. These RDDs should be switched.

A simple fix is for Graph.reverse to rebuild the routing table and replicated vertex view.

Thanks to Bogdan Ghidireac for reporting this issue on the [mailing list](http://apache-spark-user-list.1001560.n3.nabble.com/graph-reverse-amp-Pregel-API-td4338.html).

Author: Ankur Dave <[email protected]>

Closes #431 from ankurdave/fix-reverse-bug and squashes the following commits:

75d63cb [Ankur Dave] Rebuild routing table after Graph.reverse

(cherry picked from commit 235a47c)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 235a47c Apr 17, 2014
pwendell pushed a commit to pwendell/spark that referenced this pull request May 12, 2014
Describe caching and uncaching in GraphX programming guide
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
GraphImpl.reverse used to reverse edges in each partition of the edge RDD but preserve the routing table and replicated vertex view, since reversing should not affect partitioning.

However, the old routing table would then have incorrect information for srcAttrOnly and dstAttrOnly. These RDDs should be switched.

A simple fix is for Graph.reverse to rebuild the routing table and replicated vertex view.

Thanks to Bogdan Ghidireac for reporting this issue on the [mailing list](http://apache-spark-user-list.1001560.n3.nabble.com/graph-reverse-amp-Pregel-API-td4338.html).

Author: Ankur Dave <[email protected]>

Closes apache#431 from ankurdave/fix-reverse-bug and squashes the following commits:

75d63cb [Ankur Dave] Rebuild routing table after Graph.reverse
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
Describe caching and uncaching in GraphX programming guide

(cherry picked from commit ad294db)
Signed-off-by: Reynold Xin <[email protected]>
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Nov 7, 2017
mnazbro pushed a commit to mnazbro/spark that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants