Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45291][SQL][REST] Use unknown query execution id instead of no such app when id is invalid #43073

Closed
wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

This PR fixes /api/v1/applications/{appId}/sql/{executionId} API when the executionId is invalid.

Before this, we get no such app: $appId; after this, we get unknown query execution id: $executionId

Why are the changes needed?

bugfix

Does this PR introduce any user-facing change?

no, bugfix

How was this patch tested?

new test

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Sep 24, 2023
@yaooqinn
Copy link
Member Author

cc @dongjoon-hyun @HyukjinKwon, thanks

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@yaooqinn yaooqinn closed this in 5d42215 Sep 25, 2023
yaooqinn added a commit that referenced this pull request Sep 25, 2023
… such app when id is invalid

### What changes were proposed in this pull request?

This PR fixes `/api/v1/applications/{appId}/sql/{executionId}` API when the executionId is invalid.

Before this, we get `no such app: $appId`; after this, we get `unknown query execution id: $executionId`

### Why are the changes needed?

bugfix

### Does this PR introduce _any_ user-facing change?

no, bugfix

### How was this patch tested?

new test
### Was this patch authored or co-authored using generative AI tooling?

no

Closes #43073 from yaooqinn/SPARK-45291.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit 5d42215)
Signed-off-by: Kent Yao <[email protected]>
@yaooqinn
Copy link
Member Author

Thanks, merged to master and 3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants